Skip to content

fix: 이미지 변경 시 새로 렌더링 되도록 수정 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudosubin merged 5 commits into from
Apr 25, 2025
Merged

fix: 이미지 변경 시 새로 렌더링 되도록 수정 #126

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
055c2f8
fix: 이미지 변경 시 새로 렌더링 되도록 수정
sudosubin Apr 24, 2025
a38bedb
chore: fix lint errors
sudosubin Apr 24, 2025
2bc3dd0
refactor: improve image fallback handling
froggy1014 Apr 24, 2025
166ac2d
fix: replace right type annotation instead of any
froggy1014 Apr 24, 2025
eaa455a
Merge pull request #127 from sipe-team/refactor/image-fallback
froggy1014 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .script/gSheet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ function processPeopleData(peoplesRow, config) {
const row = it['_rawData'];

const thumbnailId = (row[12] ?? '').match(/\/d\/(.*?)\/view/)?.[1] ?? '';
const key = row[0] ?? Math.random().toString(36).substring(2, 15);
Copy link
Contributor

@froggy1014 froggy1014 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 그러네요. 감사합니당 ㅎ

const key = row[0] || Math.random().toString(36).substring(2, 15);
const period = row[4];

periodsMap[period].push({
Expand Down
3 changes: 2 additions & 1 deletion src/components/molecules/Image/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { CSSProperties, ReactNode, useCallback } from 'react';
import { CSSProperties, ReactNode, useCallback } from 'react';

import NextImage, { ImageProps as NextImageProps } from 'next/image';

Expand Down Expand Up @@ -72,6 +72,7 @@ function Image({
<>
{renderFillImage(
<NextImage
key={src}
Copy link
Contributor

@froggy1014 froggy1014 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키가 없었다니.

src={src}
alt={alt}
className={defaultClassName}
Expand Down