Add shortcut keys to aria-label for menu buttons#509
Closed
shysteph wants to merge 1 commit intosjdemartini:mainfrom
Closed
Add shortcut keys to aria-label for menu buttons#509shysteph wants to merge 1 commit intosjdemartini:mainfrom
shysteph wants to merge 1 commit intosjdemartini:mainfrom
Conversation
Currently only the tooltip shows the shortcut keys. Adding it to the label helps accessibility tools work.
Contributor
Author
|
@sjdemartini Any more changes you want for this? |
Owner
|
Thanks for pointing out that these weren't visible to screenreaders. I went with a slightly different approach in #539 (easier to just PR it there vs edit this). If you happen to use a screenreader, let me know if you have any issues with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only the tooltip shows the shortcut keys. Adding it to the label helps accessibility tools work.