Add aria-description for menu keyboard shortcuts#539
Merged
sjdemartini merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
sjdemartini
force-pushed
the
steven/a11y-friendly-keyboard-shortcut-descriptions
branch
from
9820325 to
46ab78e
Compare
sjdemartini
changed the title
sjdemartini
deleted the
steven/a11y-friendly-keyboard-shortcut-descriptions
branch
Contributor
|
I am not sure that is a valid use of aria-description. Description should be a longer worded description of what the the visual element is and is not fully supported yet unlike aria-describedby. I think both should be in the label or the button element should be aria-describedby the id of the tooltip popup (this is probably most correct and then I don't think it would even need a label. This is also preferred for tooltips. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach to #509 that separates from the the standard (and more important) aria-label for the element. And extends to using it in other places besides just the menu button.