-
Notifications
You must be signed in to change notification settings - Fork 12
chore: update to latests Deno and CLI standards #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a9c51cd
41958f0
291c5c5
559d88c
22b5ec8
0ed095e
aec5231
1520a46
0623db0
9f7b933
67da947
8bf6ed6
ddec837
925d328
73bb20e
b36d6ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "monthly" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| dist | ||
| package | ||
| .DS_Store | ||
| .slack/apps.dev.json | ||
| .env |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| apps.dev.json | ||
| cache/ |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes to this file might be reverted from automations of slack-samples/sample-app-configurations but I realize the changed Either before or after this pull request we should update these workflows! 🤖
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rambling now, but if we do expect these files to diverge I think it'd be best to remove paths that don't exist within a specific sample and perhaps revisit the I'm also noticing sections in the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yess I agree 💯 and I was also thinking of updating slack-samples/sample-app-configurations to use imports rather then import maps |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { Trigger } from "deno-slack-sdk/types.ts"; | ||
| import type { Trigger } from "deno-slack-sdk/types.ts"; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👁️🗨️ Good catch! |
||
| import { | ||
| TriggerContextData, | ||
| TriggerEventTypes, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📣 For sample apps this is an interesting choice that seems helpful for the current maintenance requirements across all projects of @slack-samples.