chore: update to latests Deno and CLI standards by WilliamBergamin · Pull Request #48 · slack-samples/deno-message-translator

WilliamBergamin · 2025-05-21T17:26:13Z

Type of change

New sample
New feature
Bug fix
Documentation

Summary

This PR aims to update the sample to the Deno 2 standards and the latest CLI standards.

Move content of slack.json to .slack/hooks.json
Remove dependency on mock-fetch/
Import from JSR as much as possible
Move imports from import-map.json to deno.jsonc

Requirements

I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
I've read and agree to the Code of Conduct

zimeg

@WilliamBergamin Solid set of changes here!

I'm approving now because the sample is working well for me with both run and deploy but I am hesitant on the changes to testing utilities included in the sample code.

I left a few comments on this and updates to make certain files more specific to this sample, but these are changes that might be approached in follow up PRs. Please let me know what you think about some of these 👾 ✨

.slack/.gitignore

.github/dependabot.yml

zimeg · 2025-05-21T23:07:51Z

.github/dependabot.yml

+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"


📣 For sample apps this is an interesting choice that seems helpful for the current maintenance requirements across all projects of @slack-samples.

zimeg · 2025-05-21T23:10:03Z

deno.jsonc

Changes to this file might be reverted from automations of slack-samples/sample-app-configurations but I realize the changed imports perhaps make that automation not useful now?

Either before or after this pull request we should update these workflows! 🤖

Rambling now, but if we do expect these files to diverge I think it'd be best to remove paths that don't exist within a specific sample and perhaps revisit the lock file? 🔏

I'm also noticing sections in the README.md exist for paths not found in this sample. It might be best to hold off on making these files more sample specific than import updates within these changes...

Yess I agree 💯 and I was also thinking of updating slack-samples/sample-app-configurations to use imports rather then import maps

zimeg · 2025-05-21T23:11:56Z

deno.jsonc

+    "@std/testing": "jsr:@std/testing@^1.0.12",
+    "@std/assert": "jsr:@std/assert@^1"


QQ: Do we want to use pinned patches for both of these packages? I'm optimistic of future changes to automatic updates, but I'm also confident that these stable versions should not break.

Yeah the stable versions might be our best option I haven't really given it some thought but since I'm here maybe we should

zimeg · 2025-05-21T23:15:43Z

import_map.json

zimeg · 2025-05-21T23:15:57Z

triggers/reaction_added_trigger.ts

@@ -1,4 +1,4 @@
-import { Trigger } from "deno-slack-sdk/types.ts";
+import type { Trigger } from "deno-slack-sdk/types.ts";


👁️‍🗨️ Good catch!

zimeg · 2025-05-21T23:35:41Z

functions/test_utils.ts

📝 This has complex functionalities IMO that might be confusing to include in a sample without more comments. I'm partial to wanting to avoid utils overall too. No blocker, but it'd be helpful to have comments here for now!

Also this might be a useful function to include with deno-slack-api because stubbing requests and mocking responses from https://slack.com/api is a common test case that can be useful across samples.

I believe this might be the most complex implementation of stubbing fetch across samples, other sample should not require this level of complexity, adding comments is a good idea because this is a sample!

functions/test_utils.ts

Co-authored-by: Eden Zimbelman <zim@o526.net>

zimeg · 2025-05-22T21:40:30Z

test_utils.ts

🌲 I forget exact testing conventions with filenames but could this be made into a separate test directory?

Perhaps as: ./test/http.ts 🤖

I'm not a fan of where this lives either 💯 moving to ./test/http.ts feels better

Scrapped all this and opted for an explicit stubbing pattern

zimeg

@WilliamBergamin LGTM! And thanks for exploring alternate methods of stubs and tests.

I feel a bit smarter having learned about these approaches, but agree that the inlined mocks make both the diff smaller and setups more obvious at a glance 🤓

chore: update sample to Deno 2 standards

a9c51cd

WilliamBergamin requested review from mwbrooks and zimeg May 21, 2025 17:26

WilliamBergamin self-assigned this May 21, 2025

WilliamBergamin added the update PR only - an update or maintenance is being made to an existing app label May 21, 2025

WilliamBergamin added 2 commits May 21, 2025 13:31

Fix typos

41958f0

Use Deno 2 to run CI

291c5c5

zimeg changed the title ~~chore: update sample to new standards~~ chore: update imports and dependencies to support the latest deno versions May 22, 2025

zimeg approved these changes May 22, 2025

View reviewed changes

zimeg mentioned this pull request May 22, 2025

chore: update to latests Deno and CLI standards slack-samples/deno-issue-submission#33

Merged

7 tasks

WilliamBergamin and others added 8 commits May 22, 2025 10:46

Update .slack/.gitignore

559d88c

Co-authored-by: Eden Zimbelman <zim@o526.net>

Update .github/dependabot.yml

22b5ec8

Co-authored-by: Eden Zimbelman <zim@o526.net>

improve based on feedback

0ed095e

Update README.md

aec5231

pin dependency version

1520a46

improve based on feedback

0623db0

Update dependabot.yml

9f7b933

move test_utils to the top level

67da947

zimeg reviewed May 22, 2025

View reviewed changes

WilliamBergamin changed the title ~~chore: update imports and dependencies to support the latest deno versions~~ chore: update to latests deno and CLI standards May 23, 2025

WilliamBergamin added 2 commits May 23, 2025 11:39

move testing utilities to a better location

8bf6ed6

Update deno.jsonc

ddec837

WilliamBergamin changed the title ~~chore: update to latests deno and CLI standards~~ chore: update to latests Deno and CLI standards May 23, 2025

WilliamBergamin added 3 commits May 23, 2025 12:45

Update deno.jsonc

925d328

simplify stub fetch

73bb20e

Update translate_test.ts

b36d6ec

WilliamBergamin requested a review from zimeg May 28, 2025 14:35

zimeg approved these changes May 28, 2025

View reviewed changes

WilliamBergamin merged commit 3308891 into main May 29, 2025
2 checks passed

WilliamBergamin deleted the deno-2-standards branch May 29, 2025 14:43

		"@std/testing": "jsr:@std/testing@^1.0.12",
		"@std/assert": "jsr:@std/assert@^1"

		@@ -1,4 +1,4 @@
		import { Trigger } from "deno-slack-sdk/types.ts";
		import type { Trigger } from "deno-slack-sdk/types.ts";

Conversation

WilliamBergamin commented May 21, 2025

Type of change

Summary

Requirements

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants