-
Notifications
You must be signed in to change notification settings - Fork 419
build: include the package lockfile for custom receiver example #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2744 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 37 37
Lines 7675 7675
Branches 669 669
=======================================
Hits 7172 7172
Misses 498 498
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ A comment on change below for kind reviewers alike:
| }, | ||
| "devDependencies": { | ||
| "@types/koa__router": "^12", | ||
| "@types/koa": "^3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ note: Noticed that we can perhaps prefer the koa typings here!
@koa/router is written in TypeScript and includes comprehensive type definitions out of the box. No need for
@types/*packages!
🔗 https://github.com/koajs/router?tab=readme-ov-file#typescript-support
srtaalej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ ⭐
|
@srtaalej Woo! The stars are so appreciated 🤩 🌃 ✨ I'll merge this now to unblock CI for adjacent changes, but am keeping note that we might want to revisit the lockfile of other contained examples. Let's let |
Summary
This PR adds the
package-lock.jsonfile to the custom receivers example to pin the following dependencies:@koa/[email protected]To workaround an issue with the latest
15.1.0release:🔗 https://github.com/slackapi/bolt-js/actions/runs/20244019276/job/58119249807#step:6:8
Notes
Requirements