Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Dec 15, 2025

Summary

This PR adds the package-lock.json file to the custom receivers example to pin the following dependencies:

To workaround an issue with the latest 15.1.0 release:

Error: src/KoaReceiver.ts(57,12): error TS2749: 'Router' refers to a value, but is being used as a type here. Did you mean 'typeof Router'?
Error: src/KoaReceiver.ts(90,19): error TS2749: 'Router' refers to a value, but is being used as a type here. Did you mean 'typeof Router'?
Error: src/KoaReceiver.ts(167,65): error TS7006: Parameter 'ctx' implicitly has an 'any' type.
Error: src/KoaReceiver.ts(170,69): error TS7006: Parameter 'ctx' implicitly has an 'any' type.
Error: src/KoaReceiver.ts(175,40): error TS7006: Parameter 'ctx' implicitly has an 'any' type.

🔗 https://github.com/slackapi/bolt-js/actions/runs/20244019276/job/58119249807#step:6:8

Notes

  • Other examples within this repo don't include a package lock file, but I am open to revisiting this in follow up PRs! FWIW I think we should pin dependencies of example code

Requirements

@zimeg zimeg self-assigned this Dec 15, 2025
@zimeg zimeg requested a review from a team as a code owner December 15, 2025 23:00
@zimeg zimeg added semver:patch TypeScript-specific area:examples issues related to example or sample code dependencies Pull requests that update a dependency file labels Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (d6f9ce7) to head (7011bd0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          37       37           
  Lines        7675     7675           
  Branches      669      669           
=======================================
  Hits         7172     7172           
  Misses        498      498           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ A comment on change below for kind reviewers alike:

},
"devDependencies": {
"@types/koa__router": "^12",
"@types/koa": "^3.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ note: Noticed that we can perhaps prefer the koa typings here!

@koa/router is written in TypeScript and includes comprehensive type definitions out of the box. No need for @types/* packages!

🔗 https://github.com/koajs/router?tab=readme-ov-file#typescript-support

Copy link

@srtaalej srtaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

@zimeg
Copy link
Member Author

zimeg commented Dec 15, 2025

@srtaalej Woo! The stars are so appreciated 🤩 🌃 ✨

I'll merge this now to unblock CI for adjacent changes, but am keeping note that we might want to revisit the lockfile of other contained examples. Let's let @dependabot make this next update!

@zimeg zimeg merged commit 01a1d6f into main Dec 15, 2025
19 checks passed
@zimeg zimeg deleted the zimeg-build-examples-receiver-lock branch December 15, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:examples issues related to example or sample code dependencies Pull requests that update a dependency file semver:patch TypeScript-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants