fix: removing .git from inside git template urls

[mwbrooks]

CHANGELOG

Fixes a bug when creating a project using a git repo template. If the template includes .git inside of the URL, then the template will fail to be cloned. For example, slack create --template https://github.com/slack-samples/example.git.project.git.

Summary

This pull request is a follow-up of #99 (comment) that fixes a bug when creating a project from a git repo template. If the repo name included .git inside of the name (and, optionally as the extension), then both .git references would be removed from the URL.

h/t @zimeg for noticing this bug! 🐛

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.44%. Comparing base (4406cb0) to head (80d16c1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files         212      212           
  Lines       22308    22308           
=======================================
+ Hits        14153    14154    +1     
- Misses       7067     7068    +1     
+ Partials     1088     1086    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

@mwbrooks Such a clean change - great call saving this for a follow up with tests! 🙏 ✨

I left rambling thoughts on how this might snag an edge later, but we can explore this more if an issue appears perhaps 🔍

[zimeg]

📣 This IMO is the case we ought consider as "correct" for the --template flag since it appears on the "HTTPS" tab of the Code dropdown from the sample page:

🔗 https://github.com/slack-samples/deno-starter-template
📺 https://github.com/slack-samples/deno-starter-template.git

FWIW we do not use the .git prefix in sample names but might recommend using the entire URL ending with .git if this is encountered later... Or recommend changing the sample name altogether, though I understand this can cause hassle 😉

[mwbrooks]

Thanks for the review and thoughts @zimeg! I'm glad we now have a public issue tracker, so hopefully we'll catch any other edge cases and start to make recommendations for template names! 🔠