Skip to content

fix: removing .git from inside git template urls #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 6 commits into from
May 28, 2025
Merged

fix: removing .git from inside git template urls #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9b6f0a
test: fix tests to run offline without a network connection
mwbrooks May 21, 2025
53b143a
Merge branch 'main' into mwbrooks-http-mock
mwbrooks May 21, 2025
b72d1dd
refactor: serves me right for resolving conflicts in the GitHub Editor
mwbrooks May 21, 2025
37abeef
fix: removing .git from inside git template urls
mwbrooks May 21, 2025
837c1a1
Merge branch 'main' into mwbrooks-zip-file-trim
mwbrooks May 27, 2025
80d16c1
refactor: remove unused slackdeps/http
mwbrooks May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/pkg/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ func InstallProjectDependencies(

// generateGitZipFileURL will return the GitHub zip URL for a templateURL.
func generateGitZipFileURL(httpClient slackhttp.HTTPClient, templateURL string, gitBranch string) string {
zipURL := strings.ReplaceAll(templateURL, ".git", "") + "/archive/refs/heads/"
zipURL := strings.TrimSuffix(templateURL, ".git") + "/archive/refs/heads/"

if gitBranch == "" {
mainURL := zipURL + "main.zip"
Expand Down
18 changes: 18 additions & 0 deletions internal/pkg/create/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,24 @@ func Test_generateGitZipFileURL(t *testing.T) {
httpClientMock.On("Get", mock.Anything).Return(nil, fmt.Errorf("HTTPClient error"))
},
},
"Returns the zip URL with .git suffix removed": {
templateURL: "https://github.com/slack-samples/deno-starter-template.git",
Copy link
Member

@zimeg zimeg May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 This IMO is the case we ought consider as "correct" for the --template flag since it appears on the "HTTPS" tab of the Code dropdown from the sample page:

🔗 https://github.com/slack-samples/deno-starter-template
📺 https://github.com/slack-samples/deno-starter-template.git

FWIW we do not use the .git prefix in sample names but might recommend using the entire URL ending with .git if this is encountered later... Or recommend changing the sample name altogether, though I understand this can cause hassle 😉

gitBranch: "",
expectedURL: "https://github.com/slack-samples/deno-starter-template/archive/refs/heads/main.zip",
setupHTTPClientMock: func(httpClientMock *slackhttp.HTTPClientMock) {
res := slackhttp.MockHTTPResponse(http.StatusOK, "OK")
httpClientMock.On("Get", mock.Anything).Return(res, nil)
},
},
"Returns the zip URL with .git inside URL preserved": {
templateURL: "https://github.com/slack-samples/deno.git-starter-template",
gitBranch: "",
expectedURL: "https://github.com/slack-samples/deno.git-starter-template/archive/refs/heads/main.zip",
setupHTTPClientMock: func(httpClientMock *slackhttp.HTTPClientMock) {
res := slackhttp.MockHTTPResponse(http.StatusOK, "OK")
httpClientMock.On("Get", mock.Anything).Return(res, nil)
},
},
}
for name, tt := range tests {
t.Run(name, func(t *testing.T) {
Expand Down
Loading