-
Notifications
You must be signed in to change notification settings - Fork 24
feat(bolt-install): enable bolt-install experiment by default #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 63.46% 63.47% +0.01%
==========================================
Files 212 212
Lines 22335 22336 +1
==========================================
+ Hits 14174 14178 +4
+ Misses 7070 7068 -2
+ Partials 1091 1090 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to explain the - otherwise random - changes in this PR 😅
| mockAPICreateError: slackerror.New(slackerror.ErrAppCreate), | ||
| mockAPIUpdateError: slackerror.New(slackerror.ErrAppAdd), | ||
| mockBoltExperiment: true, | ||
| mockBoltInstallExperiment: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: When turning the experiment on by default, this test failed because we hadn't explicitly disabled the experiment. In the test's title, we mention that this test case is when bolt-install is disabled.
| if clients.Runtime != nil { | ||
| isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno") | ||
| if !isDenoProject { | ||
| manifestSource = config.ManifestSourceRemote | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: When enabling the bolt-install experiment by default, a test failed due to a nil pointer reference. The default value for manifestSource is local and is set a few lines up. So when the clients.Runtime == nil, I think we can safely let he manifestSource = config.ManifestSourceLocal.
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The changelog notes are all solid for sharing the current scope of what to expect with the local run 🚢 💨
No edges noticed are so blocking to me, but I hope to follow up with a few changes also for improved error handling in ideas of an invisible manifest source 👻
Yesssss, 💯 Let's do it! |
CHANGELOG
Summary
This pull request enables the
--experiment bolt-installby default.Requirements