-
Notifications
You must be signed in to change notification settings - Fork 24
feat(bolt-install): enable bolt-install experiment by default #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -467,9 +467,11 @@ func InstallProjectDependencies( | |
| // When the BoltInstall experiment is enabled, set non-ROSI projects to ManifestSourceRemote. | ||
| if clients.Config.WithExperimentOn(experiment.BoltInstall) { | ||
| // TODO: should check if Slack hosted project, but the SDKConfig has not been initialized yet. | ||
| isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno") | ||
| if !isDenoProject { | ||
| manifestSource = config.ManifestSourceRemote | ||
| if clients.Runtime != nil { | ||
| isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno") | ||
| if !isDenoProject { | ||
| manifestSource = config.ManifestSourceRemote | ||
| } | ||
|
Comment on lines
+470
to
+474
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: When enabling the |
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: When turning the experiment on by default, this test failed because we hadn't explicitly disabled the experiment. In the test's title, we mention that this test case is when
bolt-installis disabled.