-
Notifications
You must be signed in to change notification settings - Fork 24
build: package a development and latest build for darwin architectures #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 63.48% 63.48%
=======================================
Files 212 212
Lines 22344 22344
=======================================
Hits 14184 14184
Misses 7079 7079
Partials 1081 1081 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💌 Leaving a few notes for the kind reviewers!
New archives are found in the release notes:
| - run: | ||
| name: Check expected artifacts exist | ||
| command: | | ||
| ./scripts/archive-test.sh << parameters.artifact_dir >> $BUILD_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📣 We will now fail CI if an expected executable isn't found! IIRC this has caught us off guard before with latest releases so these tests were improved too in this PR.
| - run: | ||
| name: Delete non-signed archive | ||
| command: | | ||
| rm << parameters.artifact_dir >>/slack_*_macOS_64-bit.tar.gz | ||
| rm << parameters.artifact_dir >>/slack_*_macOS_*.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looking good @zimeg! Thanks for the reviewer comments and link to your PR Release as well!
❓ I downloaded each archive and tested whether it's code signed. At the moment, only the ARM64 archives are code signed. From my understanding this PR isn't intended to fix the cod signing issue, right?
|
@mwbrooks Spot on with saving the changes to signing builds for a follow up PR! While that might've been included here, I'm hoping to test feature builds and various signing in a separate PR. I forget if signing is rate limited, but don't want to make this less obvious within these changes. |
|
@mwbrooks I also appreciate the fast review and checks so much 🤖 ✨ Let's merge this now to expand the list of available assets included with each build and release everbit more 😉 |


Summary
This PR adds the following archives and tests expected executables exist:
slack_cli_dev_macOS_amd64.tar.gzslack_cli_dev_macOS_arm64.tar.gzslack_cli_latest_macOS_amd64.tar.gzslack_cli_latest_macOS_arm64.tar.gzRequirements