Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jun 3, 2025

Changelog

Specific builds of the development and latest editions for the different Darwin architectures are now packaged.

Summary

This PR adds the following archives and tests expected executables exist:

  • slack_cli_dev_macOS_amd64.tar.gz
  • slack_cli_dev_macOS_arm64.tar.gz
  • slack_cli_latest_macOS_amd64.tar.gz
  • slack_cli_latest_macOS_arm64.tar.gz

Requirements

@zimeg zimeg added this to the Next Release milestone Jun 3, 2025
@zimeg zimeg self-assigned this Jun 3, 2025
@zimeg zimeg added changelog Use on updates to be included in the release notes semver:minor Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.48%. Comparing base (625a457) to head (1b0d2c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         212      212           
  Lines       22344    22344           
=======================================
  Hits        14184    14184           
  Misses       7079     7079           
  Partials     1081     1081           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💌 Leaving a few notes for the kind reviewers!

🔍 https://github.com/slackapi/slack-cli/releases/tag/v3.3.0-zimeg-build-unversioned-architecture-archives

New archives are found in the release notes:

assets

Comment on lines +67 to +70
- run:
name: Check expected artifacts exist
command: |
./scripts/archive-test.sh << parameters.artifact_dir >> $BUILD_VERSION
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 We will now fail CI if an expected executable isn't found! IIRC this has caught us off guard before with latest releases so these tests were improved too in this PR.

Comment on lines 280 to +283
- run:
name: Delete non-signed archive
command: |
rm << parameters.artifact_dir >>/slack_*_macOS_64-bit.tar.gz
rm << parameters.artifact_dir >>/slack_*_macOS_*.tar.gz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 An initial removal of this step missed that this step is most useful when codesigning happens before generating archives!

We continue to remove unsigned archives to repackage tarballs with the signed zip:

codesign

@zimeg zimeg marked this pull request as ready for review June 9, 2025 23:04
@zimeg zimeg requested a review from a team as a code owner June 9, 2025 23:04
@zimeg zimeg changed the title feat: package a development and latest build for darwin architectures build: package a development and latest build for darwin architectures Jun 9, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looking good @zimeg! Thanks for the reviewer comments and link to your PR Release as well!

❓ I downloaded each archive and tested whether it's code signed. At the moment, only the ARM64 archives are code signed. From my understanding this PR isn't intended to fix the cod signing issue, right?

@zimeg
Copy link
Member Author

zimeg commented Jun 9, 2025

@mwbrooks Spot on with saving the changes to signing builds for a follow up PR!

While that might've been included here, I'm hoping to test feature builds and various signing in a separate PR. I forget if signing is rate limited, but don't want to make this less obvious within these changes.

@zimeg
Copy link
Member Author

zimeg commented Jun 9, 2025

@mwbrooks I also appreciate the fast review and checks so much 🤖 ✨

Let's merge this now to expand the list of available assets included with each build and release everbit more 😉

@zimeg zimeg merged commit 50e8223 into main Jun 9, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-build-unversioned-architecture-archives branch June 9, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes changelog Use on updates to be included in the release notes semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants