Skip to content

feat: accept the app name as an argument to the 'samples' command #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Jun 26, 2025
Merged

feat: accept the app name as an argument to the 'samples' command #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26bc68a
fix: accept the app name as an argument to the 'samples' command
zimeg Jun 25, 2025
66314ac
fix: provide all arguments of the samples command to create
zimeg Jun 25, 2025
ad865e5
chore: merge w main
zimeg Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cmd/project/samples.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ var samplesLanguageFlag string

func NewSamplesCommand(clients *shared.ClientFactory) *cobra.Command {
cmd := &cobra.Command{
Use: "samples",
Use: "samples [name]",
Aliases: []string{"sample"},
Short: "List available sample apps",
Long: "List and create an app from the available samples",
Example: style.ExampleCommandsf([]style.ExampleCommand{
{Command: "samples", Meaning: "Select a sample app to create"},
{
Meaning: "Select a sample app to create",
Command: "samples my-project",
},
}),
Args: cobra.MaximumNArgs(0),
Args: cobra.MaximumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
clients.Config.SetFlags(cmd)
return runSamplesCommand(clients, cmd, args)
Expand Down Expand Up @@ -77,9 +80,7 @@ func runSamplesCommand(clients *shared.ClientFactory, cmd *cobra.Command, args [

// If preferred directory name is passed in as an argument to the `create`
// command first, honor that preference and use it to create the project
if len(args) > 0 {
createCmd.SetArgs([]string{args[0]})
}
createCmd.SetArgs(args)
Copy link
Member

@mwbrooks mwbrooks Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Ah, much more elegant!


// Execute the `create` command with the set flag
return createCmd.ExecuteContext(ctx)
Expand Down
7 changes: 5 additions & 2 deletions cmd/project/samples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
func TestSamplesCommand(t *testing.T) {
testutil.TableTestCommand(t, testutil.CommandTests{
"creates a template from a trusted sample": {
CmdArgs: []string{},
CmdArgs: []string{"my-sample-app"},
Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
createPkg.GetSampleRepos = func(client createPkg.Sampler) ([]createPkg.GithubRepo, error) {
repos := []createPkg.GithubRepo{
Expand Down Expand Up @@ -72,9 +72,12 @@ func TestSamplesCommand(t *testing.T) {
nil,
)
CreateFunc = func(ctx context.Context, clients *shared.ClientFactory, log *logger.Logger, createArgs createPkg.CreateArgs) (appDirPath string, err error) {
return "", nil
return createArgs.AppName, nil
}
},
ExpectedOutputs: []string{
"cd my-sample-app/",
},
ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
for _, call := range cm.IO.Calls {
switch call.Method {
Expand Down
Loading