Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jun 25, 2025

Changelog

Now samples can be created with a provided app name using the samples command and a provided app name with perhaps the slack samples my-app example.

Summary

This PR accepts the app name argument for the samples command.

Preview

samples.mov

Reviewers

Create even more samples at specified paths or not with these commands:

$ slack sample my-app
$ slack sample
$ slack sample /tmp/examples

Requirements

@zimeg zimeg added this to the Next Release milestone Jun 25, 2025
@zimeg zimeg self-assigned this Jun 25, 2025
@zimeg zimeg requested a review from a team as a code owner June 25, 2025 04:15
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment labels Jun 25, 2025
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (f59f7b7) to head (ad865e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   63.54%   63.59%   +0.04%     
==========================================
  Files         212      212              
  Lines       22395    22398       +3     
==========================================
+ Hits        14232    14244      +12     
+ Misses       7077     7072       -5     
+ Partials     1086     1082       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks great and this is a really nice improvement that was overlooked!

🧪 Manual testing works well and test coverage looks good.

❓ Thoughts on this being a feature rather than a bug? Our command's help clearly documented that there were no arguments and the logic prevented extra arguments. To me, this looks like an enhancement and semver:minor 😄

if len(args) > 0 {
createCmd.SetArgs([]string{args[0]})
}
createCmd.SetArgs(args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Ah, much more elegant!

@zimeg zimeg changed the title fix: accept the app name as an argument to the 'samples' command feat: accept the app name as an argument to the 'samples' command Jun 26, 2025
@zimeg zimeg added semver:minor Use on pull requests to describe the release version increment and removed semver:patch Use on pull requests to describe the release version increment labels Jun 26, 2025
@zimeg
Copy link
Member Author

zimeg commented Jun 26, 2025

@mwbrooks Thanks so much - I was confused to find this didn't match the create command which is what motivated "fix" and perhaps the comments adjacent sidetracked me...

But I notice now that documentation reflected what was found in releases so I updated this to be a "feat" and will merge it as such! 🚢 💨

@zimeg zimeg merged commit b6953db into main Jun 26, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-fix-samples-name branch June 26, 2025 23:10
@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality and removed bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants