Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jul 18, 2025

Summary

This PR is the testing continuation of #158!

Notes

Not all removed tests from #158 are returned since these might be covered in existing tests. Comments of that PR link to equivalent tests that remain or tests added here 🔏

Requirements

@zimeg zimeg self-assigned this Jul 18, 2025
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Jul 18, 2025
@zimeg zimeg changed the title test: confirm installation requirements or single choices are selected test: confirm app selection avoids regression after removing the bolt experiment Jul 18, 2025
@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.98%. Comparing base (2dbdf93) to head (261b1fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   62.95%   62.98%   +0.03%     
==========================================
  Files         212      212              
  Lines       21585    21585              
==========================================
+ Hits        13588    13595       +7     
+ Misses       6953     6947       -6     
+ Partials     1044     1043       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg marked this pull request as ready for review July 19, 2025 00:35
@zimeg zimeg requested a review from a team as a code owner July 19, 2025 00:35
@mwbrooks mwbrooks added this to the Next Release milestone Jul 21, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nice, thanks for following up with some additional test coverage! 🧪

Base automatically changed from zimeg-chore-remove-bolt-install-experiment-app-select to main July 23, 2025 06:15
@zimeg
Copy link
Member Author

zimeg commented Jul 23, 2025

@mwbrooks Of course. Thank you too for reviewing these changes and the changes of #158.

Let's merge this now and add more cases as needed 👾

@zimeg zimeg merged commit 986c433 into main Jul 23, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-test-app-select-refactors branch July 23, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants