Skip to content

test: confirm app selection avoids regression after removing the bolt experiment #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 10 commits into from
Jul 23, 2025
Merged

test: confirm app selection avoids regression after removing the bolt experiment #164

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
749b3b0
chore: default to bolt experiment behavior for app selection
zimeg Jul 17, 2025
6adb327
revert: undo changes saved for a follow up pull request
zimeg Jul 17, 2025
6df5ce2
refactor: delete unreferenced code
zimeg Jul 17, 2025
01951d8
chore: remove unused formatting functions
zimeg Jul 17, 2025
623db4c
refactor: combine the app selector and team selector
zimeg Jul 17, 2025
8466439
test: error if app id flag is not valid
zimeg Jul 17, 2025
5b9f5ab
chore: default to bolt-install experiment behavior for app selection
zimeg Jul 17, 2025
f9b74e0
test: confirm installation requirements or single choices are selected
zimeg Jul 18, 2025
ae0d602
style: remove a comment about removed mocks
zimeg Jul 18, 2025
261b1fe
chore: merge w main
zimeg Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions internal/prompts/app_select_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,27 @@ func TestPrompt_AppSelectPrompt(t *testing.T) {
Auth: fakeAuthsByTeamDomain[team2TeamDomain],
},
},
"returns installed application for app environment flag and team id flag if app saved": {
mockAuths: fakeAuthsByTeamDomainSlice,
mockAppsLocal: []types.App{
localTeam2InstalledApp,
},
mockFlagApp: "local",
mockFlagTeam: team2TeamID,
appPromptConfigEnvironment: ShowAllEnvironments,
appPromptConfigStatus: ShowInstalledAppsOnly,
expectedSelection: SelectedApp{
App: types.App{
AppID: localTeam2InstalledAppID,
TeamDomain: team2TeamDomain,
TeamID: team2TeamID,
UserID: team2UserID,
IsDev: true,
InstallStatus: types.AppStatusInstalled,
},
Auth: fakeAuthsByTeamDomain[team2TeamDomain],
},
},
"returns filtered deployed apps for app environment flag before selection": {
mockAuths: fakeAuthsByTeamDomainSlice,
mockAppsDeployed: []types.App{
Expand Down Expand Up @@ -944,6 +965,7 @@ func TestPrompt_AppSelectPrompt(t *testing.T) {
mockFlagApp: deployedTeam1InstalledAppID,
mockFlagTeam: team1TeamID,
appPromptConfigEnvironment: ShowHostedOnly,
appPromptConfigStatus: ShowAllApps,
expectedSelection: SelectedApp{
App: types.App{
AppID: deployedTeam1InstalledAppID,
Expand All @@ -966,6 +988,7 @@ func TestPrompt_AppSelectPrompt(t *testing.T) {
mockFlagApp: deployedTeam1InstalledAppID,
mockFlagTeam: team1TeamDomain,
appPromptConfigEnvironment: ShowAllEnvironments,
appPromptConfigStatus: ShowAllApps,
expectedSelection: SelectedApp{
App: types.App{
AppID: deployedTeam1InstalledAppID,
Expand Down Expand Up @@ -1015,6 +1038,7 @@ func TestPrompt_AppSelectPrompt(t *testing.T) {
mockFlagApp: "local",
mockFlagTeam: team1TeamID,
appPromptConfigEnvironment: ShowAllEnvironments,
appPromptConfigStatus: ShowAllApps,
expectedSelection: SelectedApp{
App: types.App{
AppID: localTeam1UninstalledAppID,
Expand Down Expand Up @@ -1141,6 +1165,20 @@ func TestPrompt_AppSelectPrompt(t *testing.T) {
Auth: fakeAuthsByTeamDomain[team1TeamDomain],
},
},
"returns selection for token flag if one app saved": {
mockAppsLocal: []types.App{
localTeam1UninstalledApp,
localTeam2InstalledApp,
},
mockAuthWithToken: fakeAuthsByTeamDomain[team2TeamDomain],
mockAuthWithTeamIDError: slackerror.New(slackerror.ErrCredentialsNotFound),
mockAuthWithTeamIDTeamID: mock.Anything,
mockFlagToken: fakeAuthsByTeamDomain[team2TeamDomain].Token,
expectedSelection: SelectedApp{
App: localTeam2InstalledApp,
Auth: fakeAuthsByTeamDomain[team2TeamDomain],
},
},
"errors if token flag and team id flag do not match": {
mockFlagTeam: team1TeamID,
mockFlagToken: fakeAuthsByTeamDomain[team2TeamDomain].Token,
Expand Down Expand Up @@ -1578,8 +1616,6 @@ func Test_ValidateGetOrgWorkspaceGrant(t *testing.T) {

// Test_ValidateAuth tests edge cases of the reauthentication logic for certain
// errors
//
// Successful reauthentication in other functions might use default mocks below
func Test_ValidateAuth(t *testing.T) {
apiHostDev := "https://dev.slack.com"
tests := map[string]struct {
Expand Down
Loading