-
Notifications
You must be signed in to change notification settings - Fork 24
feat: output warning of deno removal from installation scripts #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 62.97% 62.95% -0.03%
==========================================
Files 212 212
Lines 21585 21585
==========================================
- Hits 13594 13589 -5
- Misses 6945 6948 +3
- Partials 1046 1048 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📝 Open to all comments and suggestions, but I'll mark this as "ready for review" for now with plans to improve error outputs for a missing runtime in a follow up PR! |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good to me! Thanks for putting together this PR.
🖥️ Visually, this looks as good as we can hope and I appreciate that you've added some recommended next steps for folks who need to manually install Deno.
⏭️ Can we plan some follow-ups to make sure that the CLI commands error gracefully when Deno is missing and provides a link to docs on how to setup Deno?
|
@mwbrooks Thanks so much for the kind review! I'm hoping this stands out a bit more than other outputs to catch the eye, but I'm also looking forward to removing these lines from the script. Let's merge this now, but please know I'll begin a fast follow for graceful errors soon. I like the idea of including recommended docs with this! 🚢 💨 |

Summary
This PR outputs a warning that
denowill be removed from installation scripts at a future date: September 1, 2025.Preview
Requirements