-
Notifications
You must be signed in to change notification settings - Fork 24
ci: attempt deletion of branch prereleases from prior versions on merge #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Leaving wording on a perhaps unexpected change within for the kind reviewers!
| else | ||
| echo "Failed to find $TAG_NAME, trying next..." | ||
| fi | ||
| sleep 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😴 Rest is so important and I hope this helps us avoid rate limits of rapid loops!
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#about-secondary-rate-limits
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 62.91% 62.94% +0.02%
==========================================
Files 210 210
Lines 22127 22127
==========================================
+ Hits 13922 13928 +6
+ Misses 7117 7115 -2
+ Partials 1088 1084 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hello-ashleyintech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
👏🏻 This is super clever @zimeg! I hope this helps to keep our pre-releases and tags more tidy 🤞🏻
|
@hello-ashleyintech @mwbrooks Thank you both for the reviews! These will be interesting logs to inspect on merges - I'll follow up with logs of this PR as possible - and I'm too hoping we'll keep a nice list of stable versions 🙏 ✨ |
|
😌 We're looping as expected it seems: https://github.com/slackapi/slack-cli/actions/runs/14409471076/job/40413804506#step:2:26 |
Summary
This PR updates the prerelease deleting job after merges to
mainto attempt to delete all prereleases with a matching branch name for recent releases.Fixes an issue where multiple prereleases for the same PR might've been created if changes are made across a stable tag:
Preview
The following job deleted a prerelease for the "mbrooks-slackcontext-tabletestcommand" branch of #20:
https://github.com/slackapi/slack-cli/actions/runs/14363050122/job/40269188613#step:2:36
But a prerelease still exists for now of a version prior:
https://github.com/slackapi/slack-cli/releases/tag/v3.0.3-mbrooks-slackcontext-tabletestcommand
Which seems to've been created with the first commit of #20 happening before
v3.0.4while the PR was updated afterward.Notes
Requirements