Skip to content

ci: attempt deletion of branch prereleases from prior versions on merge #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Apr 11, 2025
Merged

ci: attempt deletion of branch prereleases from prior versions on merge #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d906195
ci: continue attempts to delete prereleases from prior versions on merge
zimeg Apr 10, 2025
6c92076
ci: exit with a truth value of if the release was found
zimeg Apr 10, 2025
0d6687e
Merge branch 'main' into zimeg-ci-delete-prior-prereleases
mwbrooks Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/delete-pr-build-on-close.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,21 @@ jobs:
run: |
# Figure out tag name from branch name. This is coupled to the tag name generation that exists in .circleci/config.yml's `create-github-release` job.
RELEASES=$(gh release list --repo="slackapi/slack-cli" --order="desc" --json="tagName" --exclude-drafts --exclude-pre-releases --limit=24 --jq ".[] | .tagName")
RELEASE_FOUND=1
for TAGS in $RELEASES; do
TAG_NAME="${TAGS}-${{ github.event.ref }}"
echo "Identified pre-release tagname to 🔪: $TAG_NAME"

# Delete the pre-release
if GH_DEBUG=1 gh release --repo="slackapi/slack-cli" delete "$TAG_NAME" -y --cleanup-tag; then
echo "Successfully deleted $TAG_NAME"
exit 0
RELEASE_FOUND=0
else
echo "Failed to find $TAG_NAME, trying next..."
fi
sleep 1
Copy link
Member Author

@zimeg zimeg Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😴 Rest is so important and I hope this helps us avoid rate limits of rapid loops!
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#about-secondary-rate-limits

done
echo "No matching pre-releases tag was found for the branch $TAG_NAME in recent versions"
exit 1
if [ "$RELEASE_FOUND" -ne 0 ]; then
echo "No matching pre-releases tag was found for the branch $TAG_NAME in recent versions"
fi
exit "$RELEASE_FOUND"
Loading