Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Apr 14, 2025

Summary

This PR adds an option to report the status of E2E tests to PRs made from a forked branch.

Requirements

@zimeg zimeg added semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Apr 14, 2025
@zimeg zimeg added this to the Next Release milestone Apr 14, 2025
@zimeg zimeg self-assigned this Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.93%. Comparing base (f23058b) to head (989af4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   62.92%   62.93%   +0.01%     
==========================================
  Files         210      210              
  Lines       22149    22149              
==========================================
+ Hits        13937    13940       +3     
+ Misses       7126     7125       -1     
+ Partials     1086     1084       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 A note of instruction for reviewers!

One more note is that the status won't appear when "main" is the selected workflow as these changes are not on main. For now this branch can be selected instead when testing 🦠

Comment on lines +753 to +756
- End-to-end tests for pull requests from forks can be [started][e2e] if:
- The `workflow` from the **main** branch is used
- The `branch` contains the pull request number as: `pull/123/head`
- The `status` is reported with the commit checks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimeg zimeg marked this pull request as ready for review April 14, 2025 23:08
@zimeg zimeg requested a review from a team as a code owner April 14, 2025 23:08
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This is a super clever approach will hopefully allow us to run our E2E Tests on a forked pull request, report the status to satisfy our GitHub status checks, while remaining safe and secure 🤞🏻 Great idea @zimeg!

@zimeg
Copy link
Member Author

zimeg commented Apr 14, 2025

@mwbrooks I am hoping so too 🙏 ✨

And thanks for the quick review! I'll hold off on merging right away since pre-releases remain when branches of a forked PR are deleted and of course for perhaps additional comments and more testing as needed 👾

@zimeg
Copy link
Member Author

zimeg commented Apr 14, 2025

I'll hold off on merging right away since pre-releases remain when branches of a forked PR are deleted

This is proving to be an unrelated change AFAICT! I'll instead merge this now and follow up with the changes needed. Please do stay tuned 📻

@zimeg zimeg merged commit fe3da1b into main Apr 14, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-ci-test-forks branch April 14, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants