-
Notifications
You must be signed in to change notification settings - Fork 24
ci: report test status to changes made from a forked branch #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 62.92% 62.93% +0.01%
==========================================
Files 210 210
Lines 22149 22149
==========================================
+ Hits 13937 13940 +3
+ Misses 7126 7125 -1
+ Partials 1086 1084 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nch names this workflow file is checked out with the pull request changes so this wasnt updating things as hoped
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 A note of instruction for reviewers!
One more note is that the status won't appear when "main" is the selected workflow as these changes are not on main. For now this branch can be selected instead when testing 🦠
| - End-to-end tests for pull requests from forks can be [started][e2e] if: | ||
| - The `workflow` from the **main** branch is used | ||
| - The `branch` contains the pull request number as: `pull/123/head` | ||
| - The `status` is reported with the commit checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 In rendered markdown this can be found at this branch link:
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This is a super clever approach will hopefully allow us to run our E2E Tests on a forked pull request, report the status to satisfy our GitHub status checks, while remaining safe and secure 🤞🏻 Great idea @zimeg!
|
@mwbrooks I am hoping so too 🙏 ✨ And thanks for the quick review! I'll hold off on merging right away since pre-releases remain when branches of a forked PR are deleted and of course for perhaps additional comments and more testing as needed 👾 |
This is proving to be an unrelated change AFAICT! I'll instead merge this now and follow up with the changes needed. Please do stay tuned 📻 |
Summary
This PR adds an option to report the status of E2E tests to PRs made from a forked branch.
Requirements