build(deps): bump goreleaser and configurations from v2.5.1 to v2.8.2 #4
Conversation
zimeg
added
code health
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 62.79% 62.79%
=======================================
Files 210 210
Lines 22053 22053
=======================================
Hits 13848 13848
Misses 7126 7126
Partials 1079 1079 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📝 Leaving a few links and notes on these changes for the kind reviewers!
| archives: | ||
| - id: slack | ||
| builds: | ||
| ids: |
There was a problem hiding this comment.
| format: zip | ||
| formats: | ||
| - zip |
There was a problem hiding this comment.
| snapshot: | ||
| version_template: "{{.Env.BUILD_VERSION}}" | ||
| version_template: "{{ .Env.BUILD_VERSION }}" |
There was a problem hiding this comment.
📝 Added this spacing to reduce the diff with .goreleaser.yml!
| format: zip | ||
| formats: | ||
| - zip |
There was a problem hiding this comment.
There was a problem hiding this comment.
Very subtle change. Thanks for the link!
| - binary: bin/slack | ||
| id: slack | ||
| - id: slack | ||
| binary: bin/slack |
There was a problem hiding this comment.
📝 This is perhaps opinionated, but IMO id as the first value makes parsing in the "archives" step faster!
There was a problem hiding this comment.
I definitely prefer id to be first as well!
|
📝 Hmm... I want to check how artifacts are uploaded. It seems strange that the prerelease for this branch has fewer assets than others:
|
|
🤔 I'm most confused about this: |
|
☝️ Something strange is happening with the tags used in testing. I don't believe it's related to the changes of this PR, but I'll follow up with findings! |
|
🎉 Tests are back to passing! The extra version in a tag was breaking some version checks upstream but a fixed has since landed. |
|
🔍 I'm noticing the strangeness in release artifacts might too be related to tags that might not exist since similar assets are missing from the Some investigation into this is happening in #6 and so far seems unrelated to the changes of this PR, so I'm marking this as "ready for review" once more 🫡 |
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ LGTM and safe to merge. Thanks for keeping our dev dependencies up-to-date! 🚀
| format: zip | ||
| formats: | ||
| - zip |
There was a problem hiding this comment.
Very subtle change. Thanks for the link!
| - binary: bin/slack | ||
| id: slack | ||
| - id: slack | ||
| binary: bin/slack |
There was a problem hiding this comment.
I definitely prefer id to be first as well!
mwbrooks
changed the title
|
@mwbrooks Thanks so much for helping debug the strangenesses in release notes and feature tags. For now I'm hoping we can merge this PR and revisit these as needed or sooner 👾 |
zimeg
added
build
Summary
This PR updates
goreleaserfromv2.5.1tov2.8.2and replaces deprecated options.No change to released outputs!
Requirements