Skip to content

build(deps): bump goreleaser and configurations from v2.5.1 to v2.8.2 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Apr 2, 2025
Merged

build(deps): bump goreleaser and configurations from v2.5.1 to v2.8.2 #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebb1357
build: update goreleaser and configurations from v2.5.1 to v2.8.2
zimeg Apr 1, 2025
a7e71fe
chore: merge w main
zimeg Apr 1, 2025
c706f36
Merge branch 'main' into zimeg-build-goreleaser-2.8.2
mwbrooks Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
mkdir -p ~/bin
installPath=~/bin

dlURL="https://github.com/goreleaser/goreleaser/releases/download/v2.5.1/goreleaser_Linux_x86_64.tar.gz"
dlURL="https://github.com/goreleaser/goreleaser/releases/download/v2.8.2/goreleaser_Linux_x86_64.tar.gz"
curl -sSL $dlURL | tar -xz -C ${installPath} goreleaser
- run:
name: Check GoReleaser is install success
Expand Down
5 changes: 3 additions & 2 deletions .goreleaser-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ archives:
- slack-macos
format_overrides:
- goos: windows
format: zip
formats:
- zip
Comment on lines -56 to +57
Copy link
Member Author

@zimeg zimeg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 https://goreleaser.com/deprecations/#archivesformat_overridesformat

Copy link
Member

@mwbrooks mwbrooks Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very subtle change. Thanks for the link!

name_template: >-
{{- .ProjectName }}_
{{- .Env.BUILD_VERSION }}_
Expand All @@ -64,7 +65,7 @@ archives:
{{- else }}{{ .Arch }}{{ end }}

snapshot:
version_template: "{{.Env.BUILD_VERSION}}"
version_template: "{{ .Env.BUILD_VERSION }}"
Copy link
Member Author

@zimeg zimeg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Added this spacing to reduce the diff with .goreleaser.yml!


release:
disable: true
13 changes: 7 additions & 6 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ before:
- go mod tidy -v

builds:
- binary: bin/slack
id: slack
- id: slack
binary: bin/slack
Comment on lines -24 to +25
Copy link
Member Author

@zimeg zimeg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This is perhaps opinionated, but IMO id as the first value makes parsing in the "archives" step faster!

Copy link
Member

@mwbrooks mwbrooks Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely prefer id to be first as well!

ldflags:
- "{{.Env.LDFLAGS}}"
env:
Expand All @@ -33,8 +33,8 @@ builds:
goarch:
- amd64

- binary: bin/slack
id: slack-macos
- id: slack-macos
binary: bin/slack
ldflags:
- "{{.Env.LDFLAGS}}"
goos:
Expand All @@ -48,12 +48,13 @@ builds:
'
archives:
- id: slack
builds:
ids:
Copy link
Member Author

@zimeg zimeg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 https://goreleaser.com/deprecations/#archivesbuilds

- slack
- slack-macos
format_overrides:
- goos: windows
format: zip
formats:
- zip
Comment on lines -56 to +57
Copy link
Member Author

@zimeg zimeg Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 https://goreleaser.com/deprecations/#archivesformat_overridesformat

files:
- LICENSE
name_template: >-
Expand Down
Loading