Skip to content

ci: include compiled archives in snapshot build releases #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 8 commits into from
Apr 3, 2025
Merged

ci: include compiled archives in snapshot build releases #6

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19f93c5
ci: exit with error if development or production archive builds fail
zimeg Apr 2, 2025
6078ccd
ci: exit with error from within the archive script not circle
zimeg Apr 2, 2025
ec20fcd
ci: use the most recent commit hash in changelog if no tag exists
zimeg Apr 2, 2025
cc496f3
ci: match prior feature builds when gathering the git version
zimeg Apr 2, 2025
70e8223
ci: share production compilation flags with the snapshot build
zimeg Apr 2, 2025
3e3cf9f
revert: remove adjacent updates to ci for more focused changes
zimeg Apr 2, 2025
d1e5f51
chore: merge w main
zimeg Apr 2, 2025
67bc246
style: avoid exporting ldflags used in the build snapshot step
zimeg Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ commands:
- run:
name: Output BUILD_VERSION env var based on recent git tag and type of build
command: |
BUILD_VERSION=$(git describe --tags --match 'v*.*.*' --exclude '*feature');
BUILD_VERSION=$(git describe --tags --match 'v*.*.*');
echo "git tag-based BUILD_VERSION: $BUILD_VERSION"
if [[ "<< parameters.release_ref >>" =~ ^v[0-9]+\.[0-9]+\.[0-9]+ ]]; then
# if release tag starts with semver, then this is either a prod or feature build. use the release tag, then, as build version too.
Expand Down Expand Up @@ -313,10 +313,10 @@ jobs:
echo "Overwriting existing GitHub Release data; generating pre-release notes ..."
LAST_SEMVER_TAG=$(git describe --tags --match 'v*.*.*' --abbrev=0 | cut -d"-" -f1)
# When generating release notes, setting the target tag_name property to an existing tag has GitHub ignore the target_commitish property
# So, set it to some non-existent tag name for release-note-generating purposes.
# So, set the tag to the commit hash for release-note-generating purposes.
# See https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#generate-release-notes-content-for-a-release--parameters
# Note the following _does not change releases or tags_ - it only creates release notes, just like clicking "Generate Release Notes" on the GitHub Releases page.
CHANGELOG=$(curl -L -X POST -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $GITHUB_RELEASE_TOKEN" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/slackapi/slack-cli/releases/generate-notes -d "{\"tag_name\":\"does-not-exist\",\"target_commitish\":\"${TARGET}\",\"previous_tag_name\":\"${LAST_SEMVER_TAG}\"}" | jq .body)
CHANGELOG=$(curl -L -X POST -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $GITHUB_RELEASE_TOKEN" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/slackapi/slack-cli/releases/generate-notes -d "{\"tag_name\":\"${TARGET}\",\"target_commitish\":\"${TARGET}\",\"previous_tag_name\":\"${LAST_SEMVER_TAG}\"}" | jq .body)
echo "Will use release notes: ${CHANGELOG}"
BODY+="\"body\":$CHANGELOG}"
echo "Updating existing GitHub pre-release ${RELEASE_ID} with ${BODY}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/archive.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -eo

# USAGE:
# ./scripts/archive.sh <artifact path> <release version>
Expand Down
Loading