refactor: enable linter rule ST1006 for 'poorly chosen receiver names'

[mwbrooks]

Summary

This pull request enables the linter staticcheck rule ST1006: 'Poorly chosen receiver name'.

🧠 🧠 🧠

The name of a method’s receiver should be a reflection of its identity; often a one or two letter abbreviation of its type suffices (such as “c” or “cl” for “Client”). Don’t use generic names such as “me”, “this” or “self”, identifiers typical of object-oriented languages that place more emphasis on methods as opposed to functions.

For this PR, the only change required was to remove the _ receiver name, which was used to represent an unused variable.

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.17%. Comparing base (dde98d3) to head (33852ac).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         210      210           
  Lines       22187    22187           
=======================================
  Hits        14016    14016           
  Misses       7084     7084           
  Partials     1087     1087           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

Alas so gone be the discarded value _ 🫡

Without doing a grep of all possibilities I am glad to find this rule might be generous with what's allowed. Erroring for fs would be frustrating IMO 🔍

[mwbrooks]

Thanks for the review @zimeg! 🙇🏻 I didn't know that _ was poor practice either OR that you can skip the receiver name entirely 🧠 It feels good to have these rules in place. 🚦