Skip to content

refactor: enable linter rule ST1006 for 'poorly chosen receiver names' #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 3 commits into from
May 5, 2025
Merged

refactor: enable linter rule ST1006 for 'poorly chosen receiver names' #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fe17e
refactor: enable linter ST1006 'Poorly chosen receiver name'
mwbrooks Apr 28, 2025
4802168
Merge branch 'main' into mwbrooks-lint-st1006
mwbrooks May 2, 2025
33852ac
Merge branch 'main' into mwbrooks-lint-st1006
mwbrooks May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ linters:
checks:
- all
- '-ST1005' # disable rule 'Incorrectly formatted error string'
- '-ST1006' # disable rule 'Poorly chosen receiver name'
- '-ST1008' # disable rule 'Function’s error value should be its last return value'
- '-ST1023' # disable rule 'Redundant type in variable declaration'
- '-QF1001' # disable rule 'Apply De Morgan’s law'
Expand Down
2 changes: 1 addition & 1 deletion internal/hooks/shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type ShellCommand interface {
type ShellExec struct{}

// command sets arguments for the shell supported by the current operating system
func (_ ShellExec) command(name string, arg ...string) *exec.Cmd {
func (ShellExec) command(name string, arg ...string) *exec.Cmd {
script := fmt.Sprintf("%s %s", name, strings.Join(arg, " "))
switch {
case runtime.GOOS == "windows":
Expand Down
Loading