Skip to content

Use short nullable for PHP<8 since union types are not supported #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use short nullable for PHP<8 since union types are not supported #1776

wants to merge 1 commit into from

Conversation

kkmuffme
Copy link
Contributor

Fix #1775

@kkmuffme
Copy link
Contributor Author

Quick question before I fix the test: the test fails on 7.4, however this test should not ever have passed on 7.4, since this test is a fatal error in PHP 7.4
Can I just check the PHP_VERSION_ID and skip the test in that version? Or are there any other ways implemented to run tests version specific?

Any plans to add a php -l linting pipeline to CI to prevent tests that are actually fatal errors ending up in the codebase, as well as to become aware of any issues that might be fatal in newer/older PHP versions?

@kkmuffme kkmuffme marked this pull request as ready for review August 24, 2025 23:37
@kukulich
Copy link
Contributor

PHPCS is parser so it does not run code. PHPCS on PHP 7.4 can parse and fix code with PHP 8.4 syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeHints.DNFTypeHintFormat shortNullable should be "yes" for PHP < 8
2 participants
@kkmuffme @kukulich