Skip to content

Use short nullable for PHP<8 since union types are not supported #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use short nullable for PHP<8 since union types are not supported #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SlevomatCodingStandard/Sniffs/TypeHints/DNFTypeHintFormatSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ public function process(File $phpcsFile, $pointer): void
return;
}

if ($this->shortNullable !== self::YES && SniffSettingsHelper::isEnabledByPhpVersion(null, 80000) === false) {
$this->shortNullable = self::YES;
}

$tokens = $phpcsFile->getTokens();

if ($tokens[$pointer]['code'] === T_VARIABLE) {
Expand Down
4 changes: 3 additions & 1 deletion doc/type-hints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Sniff provides the following settings:
* `enable`: either to enable or not this sniff. By default, it is enabled for PHP versions 8.0 or higher.
* `withSpacesAroundOperators`: `yes` requires spaces around `|` and `&`, `no` requires no space around `|`and `&`. None is set by default so both are enabled.
* `withSpacesInsideParentheses`: `yes` requires spaces inside parentheses, `no` requires no spaces inside parentheses. None is set by default so both are enabled.
* `shortNullable`: `yes` requires usage of `?` for nullable type hint, `no` disallows it. None is set by default so both are enabled.
* `shortNullable`: `yes` requires usage of `?` for nullable type hint, `no` disallows it. None is set by default so both are enabled. For PHP versions below 8.0 it is set to `yes` by default.
* `nullPosition`: `first` requires `null` on first position in the type hint, `last` requires last position. None is set by default so `null` can be everywhere.

#### SlevomatCodingStandard.TypeHints.LongTypeHints 🔧
Expand Down Expand Up @@ -138,6 +138,8 @@ Sniff provides the following settings:

#### SlevomatCodingStandard.TypeHints.UnionTypeHintFormat 🔧

Deprecated: Use `SlevomatCodingStandard.TypeHints.DNFTypeHintFormat` instead

Checks format of union type hints.

Sniff provides the following settings:
Expand Down
Loading