Skip to content

refactor: move Config to a separate module#836

Open
deltragon wants to merge 3 commits intoslgobinath:masterfrom
deltragon:configuration-module
Open

refactor: move Config to a separate module#836
deltragon wants to merge 3 commits intoslgobinath:masterfrom
deltragon:configuration-module

Conversation

@deltragon
Copy link
Collaborator

Description

This PR should not have any behaviour changes at all, simply moving code around to keep related logic together (and move things out of the catch-all utility module).

Unfortunately, since there is already a directory named config, I had to call the module configuration.py.

@deltragon
Copy link
Collaborator Author

@archisman-panigrahi This is ready to be merged, if you agree with the approach.

@archisman-panigrahi
Copy link
Collaborator

There is supposed to be no change in user experience, right? Only changes are about how the config is internally saved?

@deltragon
Copy link
Collaborator Author

deltragon commented Jan 22, 2026

Well, there shouldn't be any changes in this PR even internally, apart from just moving the code to a separate file.

@archisman-panigrahi
Copy link
Collaborator

I deleted all the configs and ran this. Things are working fine. However, it seems that safeeyes is not anymore creating its autostart entry. Is it intentional? Can you please confirm?

@deltragon
Copy link
Collaborator Author

I deleted all the configs and ran this. Things are working fine. However, it seems that safeeyes is not anymore creating its autostart entry. Is it intentional? Can you please confirm?

No, that is not intentional. On first run (when no ~/.config/safeeyes/safeeyes.json exists) it should create the autostart entry (in ~/.config/autostart/io.github.slgobinath.SafeEyes.desktop).
I can't reproduce the issue either. When I delete both ~/.config/safeeyes and ~/.config/autostart/io.github.slgobinath.SafeEyes.desktop, the autostart file does get recreated automatically when I start Safe Eyes on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants