Add support for PHP 8.5 #3415
Merged
Add support for PHP 8.5 #3415
+74
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to mock out the LoggerInterface's error call so that it doesn't call error_log() behind the scenes on us as this will output a new line character and cause a risky test notice.
odan
approved these changes
Nov 4, 2025
This was referenced Nov 9, 2025
Contributor
|
@akrabat Can we merge this change? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PHP 8.5 to composer.json's list of allowed PHP version and to the CI matrix. As PHP 8.5 isn't out yet, we need to ignore the platform requirement for 8.5.
Fix the deprecation warnings about setAccessible and also fix a risky test.