Update translations from Weblate #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
286bba9 to
233f804
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
0d8c5e9 to
f3fe421
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
f3fe421 to
5e186af
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
9304b62 to
9a27a11
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9a27a11 to
e4e1641
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
16db6be to
fb558dc
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
fb558dc to
bd32af7
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
bd32af7 to
2a7f922
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
f434bc9 to
91aab25
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
91aab25 to
8f32891
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
8f32891 to
459254f
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
459254f to
f66ecfb
Compare
sm-sayedi
pushed a commit
that referenced
this pull request
Jul 22, 2025
I happened to notice this message getting printed repeatedly in the
debug logs (reformatted a bit):
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception:
NetworkException: HTTP request failed. Client is already closed.
(ClientException: HTTP request failed. Client is already closed.,
uri=https://chat.zulip.org/api/v1/users/me/presence)
#0 ApiConnection.send (package:zulip/api/core.dart:175)
<asynchronous suspension>
#1 Presence._maybePingAndRecordResponse (package:zulip/model/presence.dart:93)
<asynchronous suspension>
zulip#2 Presence._poll (package:zulip/model/presence.dart:121)
<asynchronous suspension>
That'd be a symptom of an old Presence continuing to run its polling
loop after the ApiConnection has been closed, which happens when the
PerAccountStore is disposed. Looks like when we introduced Presence
in 5d43df2 (zulip#1619), we forgot to call its `dispose` method.
Fix that now.
The presence model doesn't currently have any tests. So rather than
try to add a test for just this, we'll leave it as something to
include when we write those tests, zulip#1620.
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
f66ecfb to
4e1606d
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
cab7ff7 to
62bbd1b
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
b374b9f to
676d5fa
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
e11ec00 to
c9e5062
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
c9e5062 to
620140c
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
620140c to
a24ee61
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
a24ee61 to
699210a
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
699210a to
bdbcac9
Compare
The "Channels" page and "Inbox" page both have updated designs in Figma, which we should follow. This commit matches the badges on the "Channels" page to that new design. There's more work to match the badges on the "Inbox" page, but now that work is defined crisply in a TODO: // TODO support the "kind=quantity" variant, update dartdoc Related: zulip#1406 Related: zulip#1527
The private widget, following the Figma, made the badge a bit more compact, with 1px less padding on each side, and a font size smaller by 1 (but with the same line height). That was helpful for keeping the rows at uniform height regardless of unreads (without text scaling anyway)...but I've accomplished that by adding a minimum row height (40), in the previous commit.
If Weblate has failed to rebase atop the latest tip, we would rather have the shared commit history with which to construct a (slightly out-of-date) PR, than fail because we can't fetch the `weblate` repository because we don't have any shared history.
We do this at the other sites where there's an existing controller that we want to replace with a new one. I suppose this fixes a small memory leak; I just noticed it from reading code, not from profiling or anything.
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
bdbcac9 to
ceee02a
Compare
And update Flutter's supporting libraries to match.
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
ceee02a to
6a7a598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action