chores around renovate, security context, appVersion, and fix ci testing #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
changed the title
Closed
Contributor
|
@jessebot regarding unable to use a image digest, the following works for me based on the template logic, albeit clunky. It could probably be handled more gracefully with some string parsing logic in the template though image:
repository: mattlqx/docker-pixelfed@sha256
tag: 7d1d62c8552683225456c2a552ba8ca36afb24b32f706e425310de5bf84aeab1 |
move renovate.json to the root dir and allow ignoring tests for merging GHA patch/minor updates only switch the appVersion in Chart.yaml to a specific sha tag that should actually work, until pixelfed does another official release set the securityContext and podSecurityContext to run as user 33, which is www-data to solve security root escalation issue Signed-off-by: jessebot <[email protected]>
otherwise we get Deployment.apps pixelfed-w49e3rc6mr is invalid: [metadata.labels: Invalid value: sha256-ea7cbbfe5ba933a934b47cd1029fb5dbc19d437d0aa3f1a309cb5c82226795e8.sig: must be no more than 63 characters, spec.template.labels: Invalid value: sha256-ea7cbbfe5ba933a934b47cd1029fb5dbc19d437d0aa3f1a309cb5c82226795e8.sig: must be no more than 63 characters]
jessebot
force-pushed
the
chore/update-image-tag-renovate-and-security-context
branch
from
bcdf18a to
bec985e
Compare
jessebot
changed the title
Collaborator
Author
|
@holysoles thank you! I did that to keep everyone stable for now and also now the ci tests finally work, so we can know that we haven't broken anything going forward :) |
jessebot
deleted the
chore/update-image-tag-renovate-and-security-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
move renovate.json to the root dir and allow ignoring tests for merging GHA patch/minor updates only
switch the appVersion in Chart.yaml to a -specific sha tag- that should actually work, until pixelfed does another official release. UPDATE: can't use sha because we get:
UPDATE 2: we've updated
image.repository=mattlqx/docker-pixelfed@sha256and set a sha for appVersion againset the securityContext and podSecurityContext to run as user 33, which is www-data to solve security root escalation issue
creates a values file for testing the chart in ci
make a note that
pixelfed.app.domainis requiredset
service.targetPortto8080as per the suggestion in invalid number of arguments in "server_name" directive mattlqx/docker-pixelfed#5 (comment) :)