fix(chart): access subchart generated values properly #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
reviewed
Jan 18, 2025
jessebot
reviewed
Jan 18, 2025
jessebot
reviewed
Jan 18, 2025
jessebot
approved these changes
Jan 18, 2025
Collaborator
jessebot
left a comment
jessebot
left a comment
There was a problem hiding this comment.
great work! Left some minor comments, but we'll fix those in a later PR. thanks for your contributions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was relying on the built in subchart deployment logic pretty much entirely during my first few attempts at deploying this chart, and found that while the
existingSecretfor postgres and valkey are handled well, invalid values are attempted to be access if relying on those subchart's default deployed secrets.Some information is not contained in those secrets like it is with the
existingSecrets, but they are calculated pretty simply in the subchart's templates, so have done the same here.