integration-tests/deploy: make container names unique #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 jmank88, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
jmank88
commented
Sep 15, 2025
| func ValidateDevnet() (*DevnetConfig, error) { | ||
| var errs []string | ||
| name := "chainlink-aptos.devnet" | ||
| if testing.Testing() { |
Collaborator
Author
There was a problem hiding this comment.
I suppose it doesn't need to be conditional on testing, though this is sufficient.
jmank88
force-pushed
the
pkg-concurrency
branch
from
7c97a44 to
21a455b
Compare
jmank88
force-pushed
the
pkg-concurrency
branch
from
21a455b to
a5f1fb8
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique container names in order to allow testing packages concurrently.