Skip to content

integration-tests/deploy: make container names unique #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmank88 wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −1
Open

integration-tests/deploy: make container names unique #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f1fb8
integration-tests/deploy: make container names unique
jmank88 Sep 15, 2025
f4d13dd
Merge branch 'develop' into pkg-concurrency
jmank88 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions integration-tests/deploy/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"os"
"strconv"
"strings"
"testing"
)

var (
Expand Down Expand Up @@ -214,6 +215,9 @@ func ValidateGeth() (*GethConfig, error) {
func ValidateDevnet() (*DevnetConfig, error) {
var errs []string
name := "chainlink-aptos.devnet"
if testing.Testing() {
Copy link
Collaborator Author

@jmank88 jmank88 Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it doesn't need to be conditional on testing, though this is sufficient.

name += "-" + strconv.Itoa(os.Getpid())
}

devnetImage, ok := os.LookupEnv("DEVNET_IMAGE")

Expand Down
2 changes: 1 addition & 1 deletion scripts/devnet.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

dir="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

container_name="chainlink-aptos.devnet"
container_name="chainlink-aptos.devnet-$$"
container_image="aptoslabs/tools:aptos-node-v1.34.3-hotfix"

if [ -n "${CUSTOM_IMAGE:-}" ]; then
Expand Down
Loading