Extract Generalized Write Target #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silas Lenihan <[email protected]>
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
235b954 to
a3e2644
Compare
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
a3e2644 to
f6db72a
Compare
silaslenihan
changed the title
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
3d8425d to
fbce62d
Compare
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
f790a9e to
8aaff2e
Compare
krebernisak
approved these changes
Apr 7, 2025
Contributor
krebernisak
left a comment
krebernisak
left a comment
There was a problem hiding this comment.
LGTM! Great job splitting this up.
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
8aaff2e to
541236e
Compare
This was referenced Apr 7, 2025
Closed
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
587118a to
fb2bd07
Compare
krebernisak
approved these changes
Apr 8, 2025
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
26369d5 to
4b0c8de
Compare
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
4b0c8de to
0350292
Compare
silaslenihan
temporarily deployed
to
integration
GitHub Actions
Inactive
krebernisak
requested changes
Apr 10, 2025
| mercury_v4 "github.com/smartcontractkit/chainlink-evm/pkg/report/mercury/v4" | ||
| ) | ||
|
|
||
| func DecodeAsFeedUpdated(m *wt_msg.WriteConfirmed) ([]*registry.FeedUpdated, error) { |
Contributor
There was a problem hiding this comment.
Please see and follow this comment here: smartcontractkit/chainlink-evm#24 (comment)
silaslenihan
force-pushed
the
hotfix/2.21.1-internal
branch
from
0350292 to
9ed0f5d
Compare
silaslenihan
had a problem deploying
to
integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: