Added common code needed for generalized WT #36

silaslenihan · 2025-04-03T14:21:52Z

Description

Requires Dependencies

Resolves Dependencies

Signed-off-by: Silas Lenihan <[email protected]>

… decode their chain-specific configs from it

capabilities/writetarget/write_target_test.go

capabilities/writetarget/write_target.go

dhaidashenko

Looks goode. Feel free to ignore nits

capabilities/writetarget/write_target.go

capabilities/writetarget/write_target_monitor.go

capabilities/writetarget/beholder/monitor/balance.go

capabilities/writetarget/beholder/monitor/beholder.go

capabilities/writetarget/beholder/monitor/metrics.go

capabilities/writetarget/beholder/monitor/schema.go

krebernisak

LGTM for the initial move. Nice work!

There's some structural improvements we can do in a follow up:

Extract common stuff to chainlink-common
Extract balance framework outside the /writetarget path
Extract data-feeds product specifics to a product specific repo
Inject report decoders so they can be switched by chain/product

krebernisak · 2025-04-08T09:32:09Z

capabilities/go.mod

@@ -0,0 +1,78 @@
+module github.com/smartcontractkit/chainlink-framework/capabilities


Please add a readme with short description and instructions, also point to EVM and Aptos implementations. Thx!

Can also do the same for the balance monitor part, point to Aptos implementation at least.

.github/workflows/golangci_lint.yml

krebernisak · 2025-04-08T09:51:45Z

capabilities/writetarget/write_target.go

+	cr               commontypes.ContractReader
+	cw               commontypes.ContractWriter


Wait, why do we still need cr/cw if we're now injecting a TargetStrategy interface to abstract required interactions with the chain. This is now confusing, which interface is used?

I suggest we clean this up and only use a single interface.

We still need CW to check the transaction status later, but good point we no longer need CR in the generalize wt, only in the target strategy.

capabilities/writetarget/write_target_test.go

dhaidashenko

Need to address Write Target ID generation

capabilities/go.mod

silaslenihan requested a review from a team as a code owner April 3, 2025 14:21

Added Generalized Write target

228fe8f

Signed-off-by: Silas Lenihan <[email protected]>

silaslenihan force-pushed the capabilities/write_target branch from 5b7915e to 228fe8f Compare April 3, 2025 14:24

linting fixes

0bd913d

silaslenihan force-pushed the capabilities/write_target branch from d2068cf to 0bd913d Compare April 3, 2025 19:47

silaslenihan added 2 commits April 3, 2025 18:38

cleanup

beacbab

extracted write target monitor from aptos

f24e297

silaslenihan force-pushed the capabilities/write_target branch 2 times, most recently from f3f2844 to 8c4eb17 Compare April 4, 2025 02:13

Refactored TargetStrategy methods to use request directly so they can…

39f5ab0

… decode their chain-specific configs from it

silaslenihan force-pushed the capabilities/write_target branch from 8c4eb17 to 39f5ab0 Compare April 4, 2025 15:58

dhaidashenko reviewed Apr 7, 2025

View reviewed changes

bumped go.mod

c923778

dhaidashenko reviewed Apr 7, 2025

View reviewed changes

capabilities/writetarget/write_target.go Outdated Show resolved Hide resolved

capabilities/writetarget/write_target.go Outdated Show resolved Hide resolved

capabilities/writetarget/write_target.go Outdated Show resolved Hide resolved

silaslenihan force-pushed the capabilities/write_target branch 5 times, most recently from a25a467 to 84df8e2 Compare April 7, 2025 16:59

PR feedback

b46ae76

silaslenihan force-pushed the capabilities/write_target branch from 84df8e2 to b46ae76 Compare April 7, 2025 17:21

Refactored Execute transmission state check for all statuses

ae1e95d

silaslenihan force-pushed the capabilities/write_target branch from 3205317 to ae1e95d Compare April 7, 2025 17:50

bump go.mod

64de64a

krebernisak reviewed Apr 7, 2025

View reviewed changes

capabilities/writetarget/write_target_monitor.go Outdated Show resolved Hide resolved

silaslenihan added 2 commits April 7, 2025 15:05

moved beholder code from common to framework repo

d5d5889

linting fixes / ignores

3cdd888

silaslenihan mentioned this pull request Apr 7, 2025

Extracted Generalized Aptos monitoring packages to common smartcontractkit/chainlink-common#1107

Closed

krebernisak reviewed Apr 7, 2025

View reviewed changes

silaslenihan mentioned this pull request Apr 7, 2025

Updated EVM Write target to use Generalized WT framework smartcontractkit/chainlink#17118

Merged

silaslenihan force-pushed the capabilities/write_target branch 3 times, most recently from 0874a5a to 5d2fa87 Compare April 7, 2025 22:15

addressed feedback

9e71b84

silaslenihan force-pushed the capabilities/write_target branch from 5d2fa87 to 9e71b84 Compare April 7, 2025 22:16

silaslenihan added 2 commits April 7, 2025 19:13

extracted report directory to chainlink-evm

2b529f9

removed beholder utils and retry back from common

0647c81

silaslenihan force-pushed the capabilities/write_target branch from fe89137 to a72a1f1 Compare April 8, 2025 00:12

linting fixes

510243c

silaslenihan force-pushed the capabilities/write_target branch from a72a1f1 to 510243c Compare April 8, 2025 02:08

krebernisak approved these changes Apr 8, 2025

View reviewed changes

krebernisak reviewed Apr 8, 2025

View reviewed changes

dhaidashenko reviewed Apr 8, 2025

View reviewed changes

capabilities/writetarget/write_target_test.go Outdated Show resolved Hide resolved

dhaidashenko reviewed Apr 8, 2025

View reviewed changes

jmank88 reviewed Apr 8, 2025

View reviewed changes

capabilities/go.mod Outdated Show resolved Hide resolved

silaslenihan force-pushed the capabilities/write_target branch from 2549b8d to 44c77c2 Compare April 8, 2025 13:27

Added protobuf ci

43a4fc7

silaslenihan force-pushed the capabilities/write_target branch from 44c77c2 to 43a4fc7 Compare April 8, 2025 13:28

silaslenihan added 4 commits April 8, 2025 10:10

bump go.mod

15a6ac5

implemented feedback

fa81074

Extracted all EVM-related code

d91c986

removed protobuf ci

a727f7f

silaslenihan changed the title ~~Added Generalized Write target~~ Added common code needed for generalized WT Apr 8, 2025

jmank88 approved these changes Apr 8, 2025

View reviewed changes

silaslenihan enabled auto-merge (squash) April 8, 2025 16:02

silaslenihan disabled auto-merge April 8, 2025 16:05

silaslenihan enabled auto-merge (squash) April 8, 2025 16:08

dhaidashenko approved these changes Apr 8, 2025

View reviewed changes

silaslenihan merged commit 721208f into main Apr 8, 2025
18 checks passed

silaslenihan deleted the capabilities/write_target branch April 8, 2025 16:13

		@@ -0,0 +1,78 @@
		module github.com/smartcontractkit/chainlink-framework/capabilities

Added common code needed for generalized WT #36

Added common code needed for generalized WT #36

Uh oh!

Conversation

silaslenihan commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Requires Dependencies

Resolves Dependencies

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhaidashenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krebernisak left a comment

Choose a reason for hiding this comment

Uh oh!

krebernisak Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

krebernisak Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

krebernisak Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

silaslenihan Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhaidashenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

silaslenihan commented Apr 3, 2025 •

edited

Loading