[CRE-954] Extra logging limits in WASM Module#1588
Merged
Conversation
apidiff results - no incompatible changes detected ✅Module:
|
bolekk
commented
Oct 6, 2025
jmank88
previously approved these changes
Oct 6, 2025
krehermann
previously approved these changes
Oct 6, 2025
Contributor
Author
|
I will wait for @nolag's response before merging. |
nolag
reviewed
Oct 7, 2025
nolag
reviewed
Oct 7, 2025
bolekk
force-pushed
the
chore/CRE-954-wasm-host-log-limits
branch
from
f5fcf4f to
8760557
Compare
bolekk
force-pushed
the
chore/CRE-954-wasm-host-log-limits
branch
from
8760557 to
73c6580
Compare
bolekk
force-pushed
the
chore/CRE-954-wasm-host-log-limits
branch
from
73c6580 to
62a9019
Compare
nolag
previously approved these changes
Oct 7, 2025
Contributor
nolag
left a comment
nolag
left a comment
There was a problem hiding this comment.
Approved with a comment, I haven't been on-call so I won't block it if you think it's ok to make it an error after reading my reasoning.
+ set a missing "mode" field on executor
bolekk
force-pushed
the
chore/CRE-954-wasm-host-log-limits
branch
from
1a0af5f to
6dea5c5
Compare
nolag
approved these changes
Oct 7, 2025
krehermann
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.