PLEX-1843: add node balances to beholder#280
Merged
fernandezlautaro merged 3 commits intodevelopfrom Oct 20, 2025
Merged
Conversation
fernandezlautaro
force-pushed
the
PLEX-1843_addNodeBalanceToBeholder
branch
2 times, most recently
from
197b734 to
e9a7b16
Compare
fernandezlautaro
force-pushed
the
PLEX-1843_addNodeBalanceToBeholder
branch
from
992d2f2 to
faa3f63
Compare
product-security-plaid-production
bot
requested review from
EasterTheBunny and
RayXpub
pkg/monitor/balance.go
Outdated
| } | ||
|
|
||
| metrics.NodeBalance.WithLabelValues(from.Hex(), bm.chainIDStr, metrics.EVM).Set(balanceFloat) | ||
| bm.balanceMetrics.RecordNodeBalance(context.Background(), from.Hex(), balanceFloat) |
Contributor
There was a problem hiding this comment.
we should not pass the background context as it won't be closed during the shutdown, so this call may block past the close timeout and break and cause "abnormal termination" that could be misleading.
Contributor
There was a problem hiding this comment.
nit: method no longer updates just prom metrics, so should be renamed
dhaidashenko
previously approved these changes
Oct 20, 2025
ilija42
approved these changes
Oct 20, 2025
dhaidashenko
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://smartcontract-it.atlassian.net/browse/PLEX-1843
Need node balance to be emitted in beholder besides prometheus for CREs' dashboards
requires: