PLEX-1843: add node balances to beholder#71
Merged
fernandezlautaro merged 2 commits intomainfrom Oct 20, 2025
Merged
Conversation
This was referenced Oct 17, 2025
fernandezlautaro
force-pushed
the
PLEX-1843_addNodeBalanceToBeholder
branch
from
422b2af to
424fbb6
Compare
fernandezlautaro
force-pushed
the
PLEX-1843_addNodeBalanceToBeholder
branch
from
424fbb6 to
b64db24
Compare
metrics/balance.go
Outdated
| func (m *balanceMetrics) RecordNodeBalance(ctx context.Context, account string, balance float64) { | ||
| NodeBalance.WithLabelValues(account, m.chainID, m.network).Set(balance) | ||
| m.nodeBalance.Record(ctx, balance, metric.WithAttributes( | ||
| attribute.String("network", m.network), |
Contributor
There was a problem hiding this comment.
Should not it be chainFamily instead of network to be consistent with the prom metric
Collaborator
Author
There was a problem hiding this comment.
I based this from multinode's metrics,
To me chainFamily = evm|solana|aptos while network = testnet-sepolia, did I get it wrong?
Contributor
There was a problem hiding this comment.
Agree. But prom metric uses m.network to set value for chainFamily label. Are you saying that the m.network contains testnet-sepolia and prom metric uses wrong label for it?
dhaidashenko
approved these changes
Oct 20, 2025
yashnevatia
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://smartcontract-it.atlassian.net/browse/PLEX-1843
Need node balance to be emitted in beholder besides prometheus for CREs' dashboards
Description
Requires Dependencies
Resolves Dependencies