re-write CI analysis command, separate steps/jobs, tests #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
6e621b9 to
0dc94c9
Compare
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
0dc94c9 to
a692472
Compare
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
a692472 to
04a730d
Compare
skudasov
changed the title
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
2 times, most recently
from
f9e5e93 to
4a468ec
Compare
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
4a468ec to
7bb8f39
Compare
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
7bb8f39 to
da6e88d
Compare
skudasov
force-pushed
the
ctf-ci-more-analytics
branch
from
da6e88d to
4c78b32
Compare
gheorghestrimtu
approved these changes
Mar 10, 2025
|
Tofel
reviewed
Mar 10, 2025
| // analyze jobs | ||
| for _, j := range jobs.Jobs { | ||
| stats.Mu.Lock() | ||
| defer stats.Mu.Unlock() |
Contributor
There was a problem hiding this comment.
isn't it a bad practice to call defer inside for loop?
Contributor
Author
There was a problem hiding this comment.
It leaks memory, true, however, this loop is not inside any service and runtime is very limited, so IMO that's fine.
Tofel
reviewed
Mar 10, 2025
| } else { | ||
| stats.Jobs[name].Successes++ | ||
| } | ||
| if j.Conclusion != nil && *j.Conclusion == "cancelled" { |
Contributor
There was a problem hiding this comment.
nit: define these status strings as constants?
Contributor
Author
There was a problem hiding this comment.
Yep, lemme check if GHA is exposing them
Tofel
reviewed
Mar 10, 2025
| name = name[:MaxNameLen] | ||
| } | ||
| switch typ { | ||
| case "jobs": |
Contributor
Author
There was a problem hiding this comment.
Ok, let's do this next time we'll be iterating on it
Tofel
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce enhancements and debugging features to the CI analysis tool, including new visualizations, detailed job and step analysis, and debugging capabilities. It also updates dependencies and adds a new testing utility for CI.
What
The enhancements aim to provide users with more detailed insights into their CI processes, focusing on efficiency and reliability. Debugging capabilities allow for a deeper examination of CI workflows, jobs, and steps, facilitating optimization and troubleshooting.