Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Apr 22, 2025

Why? 10s wasn't enough on some local machines


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce improvements and configurations to the Parrot Docker container environment, specifically targeting startup times and logging functionality. They ensure more flexible and error-resilient integration setups, beneficial for environments where specific timing and logging configurations are critical for the successful deployment and operation of services.

What

  • lib/.changeset/v1.54.0.md
    • Added a new changeset file to document a fix in the tc logger compatibility with version 0.36.0.
  • lib/.changeset/v1.54.1.md
    • Introduced a changeset detailing the new feature that allows configurable startup times for the Parrot Docker container.
  • lib/docker/test_env/parrot.go
    • Added defaultStartupTimeout constant set to 10 seconds, ensuring a default startup time is defined.
    • Modified NewParrot function to initialize StartupTimeout with defaultStartupTimeout if not explicitly set, providing a configurable timeout feature for the Parrot Docker container startup.

@Tofel Tofel marked this pull request as ready for review April 22, 2025 14:27
@Tofel Tofel requested a review from a team as a code owner April 22, 2025 14:27
@Tofel Tofel merged commit 8fff1ed into main Apr 22, 2025
58 checks passed
@Tofel Tofel deleted the dx-585-parrot-custom-startup-time branch April 22, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants