Skip to content

[DX-585] parrot custom startup time #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tofel merged 3 commits into from
Apr 22, 2025
Merged

[DX-585] parrot custom startup time #1795

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3313f22
allow parrot docker container to use custom startup time
Tofel Apr 22, 2025
f8fce8c
add changesets
Tofel Apr 22, 2025
25e2a63
add goimports for lib, try fix
skudasov Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/.changeset/v1.54.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix tc logger for v0.36.0
1 change: 1 addition & 0 deletions lib/.changeset/v1.54.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Make Parrot Docker container startup time configurable
7 changes: 6 additions & 1 deletion lib/docker/test_env/parrot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const (
defaultParrotImage = "kalverra/parrot"
defaultParrotVersion = "v0.6.2"
defaultParrotPort = "80"
defaultStartupTimeout = 10 * time.Second
)

// Parrot is a test environment component that wraps a Parrot server.
Expand Down Expand Up @@ -56,14 +57,18 @@ func NewParrot(networks []string, opts ...EnvComponentOption) *Parrot {
EnvComponent: EnvComponent{
ContainerName: fmt.Sprintf("%s-%s", "parrot", uuid.NewString()[0:3]),
Networks: networks,
StartupTimeout: 10 * time.Second,
},
l: log.Logger,
}
p.SetDefaultHooks()
for _, opt := range opts {
opt(&p.EnvComponent)
}

if p.StartupTimeout == 0 {
p.StartupTimeout = defaultStartupTimeout
}

return p
}

Expand Down
Loading