Include rate limit for new adapters with http transport #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
product-security-plaid-production
bot
requested a review
from cl-efornaciari
mxiao-cll
reviewed
Dec 17, 2025
| <% } -%><%= ' ' %> rateLimiting: { | ||
| tiers: { | ||
| default: { | ||
| rateLimit1m: 6, |
Contributor
There was a problem hiding this comment.
Maybe have a comment here say change this value to fit DP
Contributor
Author
There was a problem hiding this comment.
I have expanded the comment.
mxiao-cll
previously approved these changes
Dec 17, 2025
mxiao-cll
approved these changes
Dec 18, 2025
Contributor
|
🚀 Successfully created version bump PR: #650 |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapters with an
httptransport should always have a rate limit otherwise they make requests as fast as possible.This is easy to forget as it's not included in the generated boiler plate.
Changes
Include rate limit in
index.tsif the newly generated adapter has anhttptransport.Tested
Generated the adapters in smartcontractkit/external-adapters-js#4464 with and without
httptransport and with and without comments.