Skip to content

Include rate limit for new adapters with http transport #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskloetc merged 2 commits into from
Dec 18, 2025
Merged

Include rate limit for new adapters with http transport #649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
563d443
Include rate limit for new adapters with http transport
dskloetc Dec 17, 2025
c0065e6
Expand comment
dskloetc Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions scripts/generator-adapter/generators/app/templates/src/index.ts.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,21 @@ export const adapter = new Adapter({
<% if (includeComments) { -%>
// List of supported endpoints
<% } -%><%= ' ' %> endpoints: [<%= endpointNames %>],
<% if (Object.values(endpoints).some(endpoint => endpoint.inputTransports.some(({ type }) => type === 'http'))) { -%>
<% if (includeComments) { -%>
// Rate limit otherwise we send requests as fast as possible without delay.
// You should adjust this based on what the data provider can tolerate and
// how fresh you need your data to be. The rate limit is global for all
// requests going through transport.dependencies.requester, which includes
// the requests prepared in HttpTransport.prepareRequests.
<% } -%><%= ' ' %> rateLimiting: {
tiers: {
default: {
rateLimit1m: 6,
Copy link
Contributor

@mxiao-cll mxiao-cll Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have a comment here say change this value to fit DP

Copy link
Contributor Author

@dskloetc dskloetc Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have expanded the comment.

},
},
},
<% } -%>
})

export const server = (): Promise<ServerInstance | undefined> => expose(adapter)
Loading