Skip to content

Declare task output for validate and format tasks so they are incremental#155

Merged
haydenbaker merged 1 commit intomainfrom
haydenbaker/add-task-outputs
May 17, 2025
Merged

Declare task output for validate and format tasks so they are incremental#155
haydenbaker merged 1 commit intomainfrom
haydenbaker/add-task-outputs

Conversation

@haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented May 15, 2025

Background

  • These tasks do not declare any outputs, therefore they are never considered up-to-date by gradle
  • This change adds dummy outputs to these tasks
    • The real outputs are the same as the inputs, but marking the inputs as outputs becomes problematic when there are cross-project task dependencies

Testing

  • Create a project that uses the smithy jar plugin
  • Use a maven-local version, and run pTML with these changes
  • Run smithyValidate -i, verify it (and smithyFormat) runs
  • Run smithyValidate -i again, verify it (and smithyFormat) is marked up-to-date and not re-ran

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haydenbaker haydenbaker requested a review from a team as a code owner May 15, 2025 19:21
@haydenbaker haydenbaker requested a review from joewyz May 15, 2025 19:21
@haydenbaker haydenbaker force-pushed the haydenbaker/add-task-outputs branch 4 times, most recently from 5170530 to d86b4e4 Compare May 16, 2025 17:26
@haydenbaker haydenbaker force-pushed the haydenbaker/add-task-outputs branch from d86b4e4 to 4d27d6e Compare May 16, 2025 17:43
@haydenbaker haydenbaker changed the title Declare outputs for SmithyFormatTask and SmithyValidateTask Declare task output for validate and format tasks so they are incremental May 16, 2025
@haydenbaker haydenbaker merged commit 003122f into main May 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants