Skip to content

Declare task output for validate and format tasks so they are incremental #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haydenbaker merged 1 commit into from
May 17, 2025
Merged

Declare task output for validate and format tasks so they are incremental #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions smithy-base/src/main/java/software/amazon/smithy/gradle/SmithyBasePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ private void addFormatTaskForSourceSet(SourceSet sourceSet, SmithySourceDirector
formatTask -> {
formatTask.getModels().set(sds.getSourceDirectories());
formatTask.setEnabled(extension.getFormat().get());
formatTask.getOutputs().upToDateWhen(s -> true);
});

// Smithy files should be formatted before they are built
Expand Down
1 change: 1 addition & 0 deletions smithy-jar/src/main/java/software/amazon/smithy/gradle/SmithyJarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ private void addJavaTasksForSourceSet(SourceSet sourceSet, SmithyBuildTask build

// Add to verification group, so this tasks shows up in the output of `gradle tasks`
validateTask.setGroup(LifecycleBasePlugin.VERIFICATION_GROUP);
validateTask.getOutputs().upToDateWhen(s -> true);
});
project.getTasks().getByName("test").dependsOn(validateTaskProvider);
}
Expand Down