Increment member index on skipped member #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Member index was updated to use natural ordering in #510
When code generating the deserialize members, we skip members that are of union type and have the streaming trait (see here) without incrementing the index. These results in the index of subsequent members being off by 1.
This PR increments the index even in the case when a member is skipped.
Impact
This addresses the broken
invoke_model_with_response_streamoperation in theaws-sdk-bedrock-runtime.Additionally, it unblocks us from releasing a
aws-sdk-transcribe-streamingclient since it addresses issues with thestart_stream_transcriptionoperation.Testing
aws-sdk-bedrock-runtime
Example adapted from: https://docs.aws.amazon.com/nova/latest/userguide/using-invoke-api.html
When installing the latest
aws-sdk-bedrock-runtimeclient from PyPI and running the example above, the following error is thrown:With this fix I get the following response:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.