Skip to content

Increment member index on skipped member #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Increment member index on skipped member #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8fbf3d
Increment member index on skipped member
jonathan343 Oct 22, 2025
26c742f
increment once at the start of the loop
jonathan343 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...re/src/main/java/software/amazon/smithy/python/codegen/generators/StructureGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,9 @@ def _consumer(schema: Schema, de: ShapeDeserializer) -> None:
}

private void deserializeMembers(Collection<MemberShape> members) {
int index = 0;
int index = -1;
for (MemberShape member : members) {
index++;
var target = model.expectShape(member.getTarget());
if (target.hasTrait(StreamingTrait.class) && target.isUnionShape()) {
continue;
Expand All @@ -431,7 +432,7 @@ private void deserializeMembers(Collection<MemberShape> members) {
case $L:
kwargs[$S] = ${C|}
""",
index++,
index,
symbolProvider.toMemberName(member),
writer.consumer(
w -> target.accept(new MemberDeserializerGenerator(context, writer, member, "de"))));
Expand Down
Loading