feat: validate space strategies #513

wa0x6e · 2025-03-09T22:37:30Z

Toward https://github.com/snapshot-labs/workflow/issues/227
Toward https://github.com/snapshot-labs/workflow/issues/631

This PR adds validation to the space top level strategies.

Summary

It will ensure that:

top level strategies are existing strategies
top level strategies are not disabled

On both cases, it will return an error, preventing:

saving space settings with inexistent or disabled strategies
creating proposals when space settings contains inexistent or disabled strategies

The only disabled strategies right now is multichain

Changes

In order to accomplish the strategies validation, we needed to have a source of truth for valid and enabled strategies. This list will come from https://score.snapshot.org/api/strategies , and there is a new file which will poll and refresh a strategies object regularly, like on the hub.
The infinite loop is started on express.js app start, and will end gracefully on shutdown.

The validateSpaceSettings function, which was located in writer/settings.ts, has been extracted into its own file, in helper/validation.ts, since this function was also used by writer/proposal.ts
It makes more sense to have this common function inside a helper, which is also simplifying the test considerably, and avoiding duplicates tests.

Finally, there's been some refactoring in the tests, to:

extract validateSpaceSettings into its own file
remove duplicates tests in settings.tests.ts and proposals.test.ts

Test

Use SDK to send space setting with inexisting strategies
It should return error
Use SDK to send space setting with multichain strategy
It should return error

If not using an SDK, you can:

update your to use multichain strategies on production
connect your sx-ui to this sequencer branch
create a proposal on your space
sequencer should return an error
update your spaces settings (keep the multichain strategy)
sequencer should return an error

src/writer/settings.ts

ChaituVR

utAck, other than above this looks good

* fix: duplicate request preventor for EIP-1271 requests * fix test

* chore: allows 50 follows for turbo users * chore: allows 50 follows for turbo users

* fix: all copeland on production * fix: remove unused variable

Updated mantle to mnt as it's new NetworkID for it.

…524) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.54 to 0.12.55. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.54...v0.12.55) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…525) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.55 to 0.12.56. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.55...v0.12.56) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…526) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.56 to 0.12.57. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.56...v0.12.57) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) * feat: sync spaces custom domain with walletconnect allowed origins * refactor: better variable name * Update .env.example Co-authored-by: Less <[email protected]> * chore: only use domain without protocol prefix --------- Co-authored-by: Chaitanya <[email protected]> Co-authored-by: Less <[email protected]>

* feat: prevent non-premium networks * add testcases * Improve network filtering and fix test case

…#528)

* feat: use correct network when fetching shib space controller * chore: use network realm instead of chain id * fix: allow network param override

…531) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.57 to 0.12.58. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.57...v0.12.58) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.58 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add turbo tracking every 10s * fix: correct syntax for GetSpaces query * ci: deactivate schnaps for tests * refactor: rename to turbo_expiration * chore: remove quotes around url in .env.example Co-authored-by: Chaitanya <[email protected]> * refactor: only track if SCHNAPS_API_URL is set * chore: remove log * chore: remove dead env var Co-authored-by: Wan <[email protected]> * refactor: move while loop out of if condition Co-authored-by: Wan <[email protected]> * lint: fix * chore: remove track turbo status * ci: move loop in if condition * refactor: move while loop out of if condition * fix: process only relevant spaces for the instance network * fix: use sentry to capture errors * fix: use fech with keep alive * fix: fix invalid comparison * docs: add note about future feature * fix: only update `turbo_expiration` field * fix: improve sql query --------- Co-authored-by: Chaitanya <[email protected]> Co-authored-by: Wan <[email protected]>

…532) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.58 to 0.12.59. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.58...v0.12.59) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.59 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…533) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.59 to 0.12.60. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.59...v0.12.60) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.60 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: infer turbo status from turbo expiration date * fix: update schema.sql

PR updated substantially

src/writer/settings.ts

src/index.ts

src/helpers/strategies.ts

src/helpers/validation.ts

test/integration/ingestor.test.ts

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

This PR adds validation for space strategies to ensure they are valid and enabled before allowing space settings to be saved or proposals to be created. The validation includes checking that strategies exist in the official list and are not disabled (such as the multichain strategy).

Extracts space validation logic into a dedicated helper module for better code organization
Implements strategy validation against a dynamically updated list from the Score API
Adds comprehensive test coverage for the new validation functionality

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/helpers/strategies.ts`	New module that polls and caches valid strategies from the Score API
`src/helpers/spaceValidation.ts`	Extracted and enhanced space validation logic with strategy validation
`src/writer/settings.ts`	Updated to use the new validation helper
`src/writer/proposal.ts`	Updated to use the new validation helper
`src/index.ts`	Added graceful startup/shutdown for strategy polling
`test/unit/helpers/spaceValidation.test.ts`	Comprehensive tests for the new validation logic
`test/unit/writer/settings.test.ts`	Refactored tests to use mocked validation
`test/unit/writer/proposal.test.ts`	Refactored tests to use mocked validation
`test/integration/ingestor.test.ts`	Added strategy mocking for integration tests
`test/e2e/api.test.ts`	Fixed missing return statements in async operations

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-20T15:50:50Z

test/e2e/api.test.ts

@@ -58,7 +58,7 @@ describe('POST /flag', () => {
          settings: JSON.stringify(space.settings)
        }))
        .map(async space => {
-          db.queryAsync('INSERT INTO snapshot_sequencer_test.spaces SET ?', space);
+          return db.queryAsync('INSERT INTO snapshot_sequencer_test.spaces SET ?', space);


This return statement inside a map callback doesn't affect the outer function's return value. The map is creating an array of promises but they're not being awaited. Consider using Promise.all() to properly handle the async operations.

Copilot · 2025-08-20T15:50:50Z

test/e2e/api.test.ts

@@ -75,7 +75,7 @@ describe('POST /flag', () => {
          vp_value_by_strategy: JSON.stringify(proposal.vp_value_by_strategy || [])
        }))
        .map(async proposal => {
-          db.queryAsync('INSERT INTO snapshot_sequencer_test.proposals SET ?', proposal);
+          return db.queryAsync('INSERT INTO snapshot_sequencer_test.proposals SET ?', proposal);


Same issue as above - this return statement inside a map callback doesn't affect the outer function's return value. The map is creating an array of promises but they're not being awaited. Consider using Promise.all() to properly handle the async operations.

src/index.ts

src/helpers/spaceValidation.ts

ChaituVR

tAck

except few small comments above

ChaituVR · 2025-08-22T21:57:09Z

we can merge when you are ready

wa0x6e requested a review from Copilot March 9, 2025 22:37

This comment was marked as outdated.

Sign in to view

wa0x6e force-pushed the feat-validate-space-strategies branch from 0188a18 to 5d8276d Compare March 9, 2025 22:58

feat: validate space strategies

fac6311

wa0x6e force-pushed the feat-validate-space-strategies branch from 5d8276d to fac6311 Compare March 9, 2025 23:15

wa0x6e marked this pull request as ready for review March 10, 2025 17:49

wa0x6e requested a review from ChaituVR March 11, 2025 11:45

ChaituVR requested changes Mar 12, 2025

View reviewed changes

src/writer/settings.ts Outdated Show resolved Hide resolved

src/writer/settings.ts Outdated Show resolved Hide resolved

src/writer/settings.ts Outdated Show resolved Hide resolved

ChaituVR previously approved these changes Mar 14, 2025

View reviewed changes

ChaituVR and others added 21 commits August 13, 2025 02:34

fix: duplicate request preventor for EIP-1271 requests (#515)

09cde68

* fix: duplicate request preventor for EIP-1271 requests * fix test

chore: increase follow limit for Turbo users (#516)

611e081

* chore: allows 50 follows for turbo users * chore: allows 50 follows for turbo users

fix: allow copeland on production (#517)

4d8f1ad

* fix: all copeland on production * fix: remove unused variable

feat: use unified API to check if SX space exists (#520)

ae2a23f

feat: add mnt, ape, curtis to networks whitelist (#521)

badd12a

Updated mantle to mnt as it's new NetworkID for it.

fix: prevent non-premium networks (#522)

a1dee26

* feat: prevent non-premium networks * add testcases * Improve network filtering and fix test case

fix: allow turbo spaces to create proposals with non-premuim networks (…

a21aaca

…#528)

feat: use correct network when fetching shib space controller (#527)

da6af19

* feat: use correct network when fetching shib space controller * chore: use network realm instead of chain id * fix: allow network param override

chore: use pineapple gateway to get JSON on poke (#535)

61578e2

fix: skip indexing from outdated schnaps api (#537)

dcde46a

fix: assign fallback value (#538)

5adf223

fix: infer turbo status from turbo expiration date (#539)

815b897

* fix: infer turbo status from turbo expiration date * fix: update schema.sql

chore: mark eden-online-override strategy as overriding

fa1b786

wa0x6e and others added 2 commits August 19, 2025 20:00

feat: only allow override strategies on pro spaces (#581)

6c57cdf

Merge branch 'master' into feat-validate-space-strategies

e7f0ecf

ChaituVR requested changes Aug 19, 2025

View reviewed changes

refactor: better filename to avoid confusion

ea54370

wa0x6e force-pushed the feat-validate-space-strategies branch from 6cfb5ea to ea54370 Compare August 20, 2025 14:01

wa0x6e added 3 commits August 20, 2025 18:04

fix: increase refresh interval to 5min

e5e4e8c

fix: start express app only after loading all strategies

6fc5edb

tests: mock strategies list

28e34f2

wa0x6e requested a review from Copilot August 20, 2025 15:34

This comment was marked as outdated.

Sign in to view

wa0x6e and others added 3 commits August 21, 2025 00:36

Update src/helpers/strategies.ts

87184eb

Co-authored-by: Copilot <[email protected]>

tests: fix race condition in E2E tests

3fe0ba1

fix: strategy should honor the Strategy signature

87bb640

wa0x6e requested a review from Copilot August 20, 2025 15:50

Copilot AI reviewed Aug 20, 2025

View reviewed changes

wa0x6e added 2 commits August 20, 2025 20:06

fix: throw error on internal error from score-api

83e61c8

fix: use getter to avoid reference invalidation

09ba5a1

wa0x6e requested a review from ChaituVR August 20, 2025 18:34

refactor: use default argument

cb2a274

wa0x6e force-pushed the feat-validate-space-strategies branch from 08ab602 to cb2a274 Compare August 20, 2025 18:43

ChaituVR reviewed Aug 22, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

ChaituVR reviewed Aug 22, 2025

View reviewed changes

src/helpers/spaceValidation.ts Outdated Show resolved Hide resolved

ChaituVR approved these changes Aug 22, 2025

View reviewed changes

fix: use single quote

01a27e4

wa0x6e force-pushed the feat-validate-space-strategies branch from 4217967 to 01a27e4 Compare August 22, 2025 17:06

fix: delay first strategies loop run

35d40b7

wa0x6e merged commit 7277e60 into master Aug 22, 2025
2 checks passed

wa0x6e deleted the feat-validate-space-strategies branch August 22, 2025 21:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: validate space strategies #513

feat: validate space strategies #513

Uh oh!

wa0x6e commented Mar 9, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Uh oh!

ChaituVR commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

feat: validate space strategies #513

feat: validate space strategies #513

Uh oh!

Conversation

wa0x6e commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Choose a reason for hiding this comment

Uh oh!

ChaituVR commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

wa0x6e commented Mar 9, 2025 •

edited

Loading