-
Notifications
You must be signed in to change notification settings - Fork 14
feat: set proposal's strategies fiat value #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wa0x6e
wants to merge
20
commits into
master
Choose a base branch
from
feat-get-proposal-vp-value-from-overlord
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix types
fix: fix botched merge conflict chore: remove typo fix: fix typescript error fix: fix lint error fix: delete unused file
cba84ce
to
ed31f78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances proposal voting power value calculation by integrating with the Overlord service to fetch and store precise strategy valuations during proposal creation.
- Implements fetching of strategy fiat values from Overlord service during proposal validation
- Stores strategy values in the
vp_value_by_strategy
database field with 9-decimal precision - Refactors JSON RPC request logic into a reusable utility function
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/writer/proposal.ts |
Adds strategy value fetching during proposal verification and stores values in database |
src/helpers/entityValue.ts |
New module providing centralized strategy value calculation logic |
src/helpers/utils.ts |
Adds reusable jsonRpcRequest utility function |
src/helpers/shutter.ts |
Refactored to use new jsonRpcRequest utility |
test/unit/writer/proposal.test.ts |
Updates test expectations and mocks for new proposal verification behavior |
test/integration/writer/proposal.test.ts |
Updates integration tests to handle new action signature |
test/integration/ingestor.test.ts |
Adds mocking for entityValue module |
package.json |
Updates Node.js types dependency |
.env.example |
Adds new environment variable and fixes typo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced Proposal Voting Power Value Calculation
This PR implements comprehensive voting power value calculation for proposals by integrating with the Overlord service
to provide more accurate and precise strategy valuations.
Key Features
🎯 Core Enhancement:
🔧 Technical Improvements:
🛠️ Code Quality:
🔄 Refactoring:
Testing
erc-20-balance-of
strategies (+ other)vp_value_by_strategy
column should contain an array of values: the token unit price of each strategy token, or 0 when unsupported. Array contains as many items as strategies