Skip to content

Conversation

@sfc-gh-gjachimko
Copy link

🤖 Generated with Claude Code

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.
  • I've described my changes in the documentation.

Changes description

...

@sfc-gh-gjachimko sfc-gh-gjachimko requested a review from a team as a code owner October 29, 2025 12:59
build-docker.sh Outdated
Comment on lines 14 to 18
echo "Image: snowflake-cli:latest"
echo ""
echo "Usage:"
echo " docker run --rm snowflake-cli --version"
echo " docker run --rm snowflake-cli --help"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage examples reference snowflake-cli as the image name, but the PR title mentions creating a snow-cli container. For consistency, either:

  1. Update these examples to use snow-cli:

    docker run --rm snow-cli --version
    docker run --rm snow-cli --help
    
  2. Or ensure the Docker build process uses snowflake-cli as the image name throughout the implementation.

Maintaining consistent naming will prevent confusion for users following these examples.

Suggested change
echo "Image: snowflake-cli:latest"
echo ""
echo "Usage:"
echo " docker run --rm snowflake-cli --version"
echo " docker run --rm snowflake-cli --help"
echo "Image: snow-cli:latest"
echo ""
echo "Usage:"
echo " docker run --rm snow-cli --version"
echo " docker run --rm snow-cli --help"

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants